From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
David Spinadel <david.spinadel@intel.com>
Subject: Re: [PATCH v5 2/3] mac80211: support FTM responder configuration/statistics
Date: Mon, 01 Oct 2018 12:14:55 +0200 [thread overview]
Message-ID: <1538388895.3126.26.camel@sipsolutions.net> (raw)
In-Reply-To: <1537489811-5752-3-git-send-email-pradeepc@codeaurora.org>
On Thu, 2018-09-20 at 17:30 -0700, Pradeep Kumar Chitrapu wrote:
> New bss param ftm_responder is used to notify the driver to
> enable fine timing request (FTM) responder role in AP mode.
>
> Plumb the new cfg80211 API for FTM responder statistics through to
> the driver API in mac80211.
This patch also doesn't apply right now, please rebase & add the struct
as previously pointed out. That also affects the driver, perhaps, so
please resend that as well.
> + if (params->ftm_responder != -1) {
> + sdata->vif.bss_conf.ftm_responder = params->ftm_responder;
> + err = ieee80211_set_ftm_responder_params(sdata,
> + params->lci,
> + params->lci_len,
> + params->civicloc,
> + params->civicloc_len);
> +
> + if (err < 0)
> + return err;
> +
> + changed |= BSS_CHANGED_FTM_RESPONDER;
> + } else {
> + sdata->vif.bss_conf.ftm_responder = -1;
> + }
This seems wrong - you should remove the else branch entirely, afaict?
I think you may also be missing some freeing of the ftm_responder_params
in the end if it didn't get disabled again, but the interface is
removed?
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-10-01 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 0:30 [PATCH v5 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-09-21 0:30 ` [PATCH v5 1/3] cfg80211: support FTM " Pradeep Kumar Chitrapu
2018-10-01 10:12 ` Johannes Berg
2018-09-21 0:30 ` [PATCH v5 2/3] mac80211: " Pradeep Kumar Chitrapu
2018-10-01 10:14 ` Johannes Berg [this message]
2018-09-21 0:30 ` [PATCH v5 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538388895.3126.26.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=david.spinadel@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox