From: Kalle Valo <kvalo@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath10k: fix QCOM_SMEM dependency
Date: Fri, 2 Dec 2022 18:24:46 +0000 (UTC) [thread overview]
Message-ID: <167000548228.19912.958966715275438470.kvalo@kernel.org> (raw)
In-Reply-To: <20221202103027.25974-1-kvalo@kernel.org>
Kalle Valo <kvalo@kernel.org> wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> Nathan noticed that when HWSPINLOCK is disabled there's a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for QCOM_SMEM
> Depends on [n]: (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && HWSPINLOCK [=n]
> Selected by [m]:
> - ATH10K_SNOC [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH10K [=m] && (ARCH_QCOM [=y] || COMPILE_TEST [=n])
>
> The problem here is that QCOM_SMEM depends on HWSPINLOCK so we cannot select
> QCOM_SMEM and instead we neeed to use 'depends on'.
>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Link: https://lore.kernel.org/all/Y4YsyaIW+CPdHWv3@dev-arch.thelio-3990X/
> Fixes: 4d79f6f34bbb ("wifi: ath10k: Store WLAN firmware version in SMEM image table")
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to wireless-next.git, thanks.
d03407183d97 wifi: ath10k: fix QCOM_SMEM dependency
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221202103027.25974-1-kvalo@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2022-12-02 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 10:30 [PATCH] wifi: ath10k: fix QCOM_SMEM dependency Kalle Valo
2022-12-02 18:24 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167000548228.19912.958966715275438470.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox