From: Sven Eckelmann <seckelmann@datto.com>
To: ath10k@lists.infradead.org
Cc: Maharaja Kennadyrajan <mkenna@codeaurora.org>,
Maharaja Kennadyrajan <c_mkenna@qti.qualcomm.com>
Subject: Re: ath10k: TPC: Max antenna gain
Date: Tue, 11 Jun 2019 14:14:59 +0200 [thread overview]
Message-ID: <1812561.GRj0lRSQoq@bentobox> (raw)
In-Reply-To: <17533428.x5EMhTv9h2@bentobox>
[-- Attachment #1.1: Type: text/plain, Size: 1075 bytes --]
On Tuesday, 11 June 2019 12:59:25 CEST Sven Eckelmann wrote:
> Hi,
>
> the firmware doesn't seem to parse the max_antenna gain from
> ath10k_update_channel_list anymore. At least the
> /sys/kernel/debug/ieee80211/phy0/ath10k/tpc_stats shows me max antenna gain 0
> when I set it in ath10k_update_channel_list to 12.
[...]
Just checked the code a little bit more and there seem to be two problems. One
is in ath10k and the other one is in my PoC change. The problem in the latter
is the missing change in the vdev_restart.
But the problem in ath10k is more interesting. It seems to be that the
firmware expects the max_antenna_gain in dBm but the ath10k driver sends it in
twicepower (0.5 dBm steps). At least this is what I see in tpc_stats when
setting all max_antenna_gain to 12.
And the funniest part is that the configured 9 dBm is shown as 12 twicepower
(6 dB) in tpc_stats for 5GHz PHYs when using the US country code (but not when
using Germany or checking 2.4GHz PHYs). Is there some hardcoded limiter in the
firmware for FCC 5GHz?
Kind regards,
Sven
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2019-06-11 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:59 ath10k: TPC: Max antenna gain Sven Eckelmann
2019-06-11 12:14 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1812561.GRj0lRSQoq@bentobox \
--to=seckelmann@datto.com \
--cc=ath10k@lists.infradead.org \
--cc=c_mkenna@qti.qualcomm.com \
--cc=mkenna@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox