ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
	ath10k@lists.infradead.org
Subject: Re: Anyone get txbf to work on ath10k when using the linux driver?
Date: Mon, 13 Nov 2017 19:10:07 -0800	[thread overview]
Message-ID: <1d1fd019-cb3e-17e5-f7d5-dfe1debf95d5@candelatech.com> (raw)
In-Reply-To: <c685ebc0-4d7a-104d-7bf1-d143227f7d48@dd-wrt.com>



On 11/13/2017 06:05 PM, Sebastian Gottschall wrote:
> Am 13.11.2017 um 23:50 schrieb Ben Greear:
>> From what I can tell, the 10.4 firmware will not even enable txbf unless the driver
>> tells it too, and I don't think the driver is doing the correct call to enable this
>> (it is a testing interface hack, it appears).
>>
>> But, maybe I am missing something?
> so the firmware does not take care about the vht flags?

There is a flag to enable implicit beamforming, but it is mis-defined
in the driver as far as I can tell:

diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index ff15c37..9522f22 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -5195,7 +5195,8 @@ enum wmi_10_4_vdev_param {
  #define WMI_VDEV_PARAM_TXBF_MU_TX_BFER BIT(3)

  #define WMI_TXBF_STS_CAP_OFFSET_LSB    4
-#define WMI_TXBF_STS_CAP_OFFSET_MASK   0xf0
+#define WMI_TXBF_STS_CAP_OFFSET_MASK   0x70
+#define WMI_TXBF_CONF_IMPLICIT_BF       BIT(7)
  #define WMI_BF_SOUND_DIM_OFFSET_LSB    8
  #define WMI_BF_SOUND_DIM_OFFSET_MASK   0xf00


Possibly that bit is somehow set anyway, dunno.

And the other explicit-beamforming appears to need a special hack to enable
the feature in the firmware.

But, someone using my firmware gets txbf to work, so I must be missing something.

I will dig into it more tomorrow.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2017-11-14  3:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 22:50 Anyone get txbf to work on ath10k when using the linux driver? Ben Greear
2017-11-14  2:05 ` Sebastian Gottschall
2017-11-14  3:10   ` Ben Greear [this message]
2017-11-14 22:17     ` Ben Greear
2017-11-14 22:19       ` Sebastian Gottschall
2017-11-16 18:55         ` Ben Greear
2017-11-20 14:09           ` Sebastian Gottschall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d1fd019-cb3e-17e5-f7d5-dfe1debf95d5@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=s.gottschall@dd-wrt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox