From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ath10k: Add support to configure pktlog filter
Date: Mon, 6 Oct 2014 17:36:58 +0530 [thread overview]
Message-ID: <20141006120656.GA19615@qca.qualcomm.com> (raw)
In-Reply-To: <877g0dl8j6.fsf@kamboji.qca.qualcomm.com>
On Mon, Oct 06, 2014 at 02:52:45PM +0300, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
>
> > Add support to configure packet log filters (tx, rx, rate control)
> > via debugfs. To disable htt pktlog events set the filters to 0.
> >
> > ex:
> >
> > To enable pktlog for all filters
> >
> > echo 0x1f > /sys/kernel/debug/ieee80211/phy*/ath10k/pktlog_filter
> >
> > To disable pktlog
> >
> > echo 0 > /sys/kernel/debug/ieee80211/phy*/ath10k/pktlog_filter
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
>
> I did minor changes to the error handling in
> ath10k_write_pktlog_filter() and in ath10k_debug_start(). Diff below and
> full commit here:
>
> https://github.com/kvalo/ath/commit/470c43d83b7ee4147dea38a4f7b986070555a032
>
> Please review my changes.
>
LGTM. We need Michal's tracepoint changes other than pktlog. I do not have his
latest version of the change.
-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-10-06 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 17:09 [PATCH v2 0/4] ath10k: Add pktlog support Rajkumar Manoharan
2014-10-02 17:09 ` [PATCH v2 1/4] ath10k: Add support to configure pktlog filter Rajkumar Manoharan
2014-10-06 11:52 ` Kalle Valo
2014-10-06 12:06 ` Rajkumar Manoharan [this message]
2014-10-06 12:11 ` Kalle Valo
2014-10-02 17:09 ` [PATCH v2 2/4] ath10k: add tracing for ath10k_htt_pktlog Rajkumar Manoharan
2014-10-02 17:09 ` [PATCH v2 3/4] ath10k: add tracing for rx descriptor Rajkumar Manoharan
2014-10-02 17:09 ` [PATCH v2 4/4] ath10k: add tracing for tx info Rajkumar Manoharan
2014-10-07 14:15 ` [PATCH v2 0/4] ath10k: Add pktlog support Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006120656.GA19615@qca.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox