From: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: senthilb@qti.qualcomm.com, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k:Prevent setting wrong key idx for station
Date: Wed, 28 Jan 2015 15:51:01 +0530 [thread overview]
Message-ID: <20150128102059.GA22295@senthilj-ThinkPad-L430> (raw)
In-Reply-To: <20150128095205.GA22052@senthilj-ThinkPad-L430>
On Wed, Jan 28, 2015 at 03:22:07PM +0530, SenthilKumar Jegadeesan wrote:
> On Wed, Jan 28, 2015 at 10:23:35AM +0200, Kalle Valo wrote:
> > <senthilb@qti.qualcomm.com> writes:
> >
> > > From: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
> > >
> > > Ath10k driver sets wrong default key idx that results in
> > > sending unicast frames with multicast key.
> > >
> > > The reason for this behavior is that cached broadcast key
> > > is installed for station MAC address on association. After
> > > dot1x completes, unicast key is installed for station
> > > MAC address. Default key idx is set to broadcast key id when
> > > driver tries to send broadcast frame. This causes firmware
> > > to use broadcast key id to transmit unicast frames to stations.
> > >
> > > Used TX_USAGE flag to set default key for stations.
> > >
> > > Added callback for setting unicast default idx which will be
> > > invoked on every default key idx configuration.
> > >
> > > Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
> >
> > I had a trivial conflict in ath10k_add_interface(), please double check
> > my conflict resolution in the pending branch:
> >
> > https://github.com/kvalo/ath/commit/34e5197d250d7be04bba5ad2b2d33cd9a7c41b0f
> >
> > And in the future please also CC linux-wireless when submitting ath10k
> > patches.
> >
> Kalle,
>
> Confilcts aren't resolved properly. I will re-send the patch from top of the
> branch.
>
The conflicts are resolved correclty. Sorry for the confusion.
Thanks,
Senthil J
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-01-28 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 14:30 [PATCH] ath10k:Prevent setting wrong key idx for station senthilb
2015-01-27 16:58 ` Ben Greear
2015-01-29 10:31 ` Kalle Valo
2015-01-29 12:31 ` SenthilKumar Jegadeesan
2015-01-29 15:00 ` Ben Greear
2015-01-28 8:23 ` Kalle Valo
2015-01-28 9:52 ` SenthilKumar Jegadeesan
2015-01-28 10:21 ` SenthilKumar Jegadeesan [this message]
2015-02-04 7:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128102059.GA22295@senthilj-ThinkPad-L430 \
--to=sjegadee@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=senthilb@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox