From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: ath10k: fix peer limit enforcement
Date: Wed, 19 Aug 2015 15:41:08 +0300 [thread overview]
Message-ID: <20150819124108.GL5610@mwanda> (raw)
In-Reply-To: <CA+BoTQnShiN8LGhqqnNuqO_7FpPORRasH8p8j2uU9CHTm1Rudw@mail.gmail.com>
On Wed, Aug 19, 2015 at 01:19:32PM +0200, Michal Kazior wrote:
> On 18 August 2015 at 21:01, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > Hello Michal Kazior,
> >
> > The patch e04cafbc38c7: "ath10k: fix peer limit enforcement" from Aug
> > 5, 2015, leads to the following static checker warning:
> >
> > drivers/net/wireless/ath/ath10k/mac.c:4365 ath10k_add_interface()
> > warn: inconsistent returns 'mutex:&ar->conf_mutex'.
> > Locked on: line 4125
> > Unlocked on: line 4344
> > line 4365
> [...]
>
> Great job finding this and the other one (dma_mapping_error) as well!
> I've just sent patches to fix them.
I re-wrote the dma_mapping_error() check yesteday but I will push it
soon.
>
> I'd love to have this sort of static analysis in my tool set. What did
> you use (I have a weird feeling I did ask about it at one point..)?
This is a Smatch warning.
regards,
dan carpenter
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-08-19 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 19:01 ath10k: fix peer limit enforcement Dan Carpenter
2015-08-19 11:19 ` Michal Kazior
2015-08-19 12:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819124108.GL5610@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ath10k@lists.infradead.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox