From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Mon, 14 Sep 2015 09:03:48 -0700 From: Greg KH Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes Message-ID: <20150914160348.GA7290@kroah.com> References: <81516fb9c662cc338b5af5b63fbbcde5374e0893.1442202447.git.viresh.kumar@linaro.org> <1708603.aKpYchk1pa@wuerfel> <20150914154708.GF32551@linux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150914154708.GF32551@linux> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Viresh Kumar Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Avri Altman , Stanislaw Gruszka , Jiri Slaby , "open list:DOCUMENTATION" , Peter Zijlstra , Catalin Marinas , Sebastian Andrzej Siewior , Jaroslav Kysela , "open list:MEMORY MANAGEMENT" , Kalle Valo , Emmanuel Grumbach , Luciano Coelho , Richard Fitzgerald , Ingo Molnar , Hariprasad S , Thomas Gleixner , Davidlohr Bueso , Eliad Peller , Johannes Berg , Joonsoo Kim , Jonathan Corbet , Joerg Roedel , "open list:WOLFSON MICROELECTRONICS DRIVERS" , Sebastian Ott , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , Intel Linux Wireless , "open list:ACPI" , Dmitry Monakhov , Nick Kossifidis , Doug Thompson , Gustavo Padovan , Sasha Levin , Tomas Winkler , sboyd@codeaurora.org, "open list:B43 WIRELESS DRIVER" , linaro-kernel@lists.linaro.org, Johan Hedberg , Arnd Bergmann , Mauro Carvalho Chehab , Arik Nemtsov , Marcel Holtmann , David Rientjes , Michal Hocko , Akinobu Mita , Andrew Morton , Joe Perches , Mark Brown , Borislav Petkov , Oleg Nesterov , Florian Fainelli , Charles Keepax , Mel Gorman , Vlastimil Babka , "open list:EDAC-CORE" , "moderated list:ARM64 PORT AARCH64 ARCHITECTURE" , Haggai Eran , "James E.J. Bottomley" , Alexander Duyck , Chaya Rachel Ivgi , "open list:CISCO SCSI HBA DRIVER" , Brian Silverman , "Luis R. Rodriguez" , "open list:CXGB4 ETHERNET DRIVER CXGB4" , "open list:ULTRA-WIDEBAND UWB SUBSYSTEM:" , "open list:NETWORKING DRIVERS WIRELESS" , Takashi Iwai , Sesidhar Baddela , open list , Johannes Weiner , "open list:BLUETOOTH DRIVERS" , "open list:AMD IOMMU AMD-VI" , "open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER" , Rafael Wysocki , Narsimhulu Musini , Wang Long , Tejun Heo , Michael Kerrisk , QCA ath9k Development , Len Brown , Liam Girdwood , Larry Finger On Mon, Sep 14, 2015 at 09:17:08PM +0530, Viresh Kumar wrote: > On 14-09-15, 17:39, Arnd Bergmann wrote: > > On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > > > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > > > index b4c216bab22b..bea8e425a8de 100644 > > > --- a/drivers/acpi/ec_sys.c > > > +++ b/drivers/acpi/ec_sys.c > > > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) > > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) > > > goto error; > > > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, > > > - (u32 *)&first_ec->global_lock)) > > > + &first_ec->global_lock)) > > > goto error; > > > > > > if (write_support) > > > > This one might need a separate patch that can be backported to stable, as > > the original code is already broken on big-endian 64-bit machines: > > global_lock is 'unsigned long'. > > Hmmm, so you suggest a single patch that will do s/unsigned long/u32 > and that will be followed with this patch (almost) as is. Right? > > Also, regarding the stable thing, we will surely not be able to > backport it straight away. But we should get it backported for sure. > > @Greg: What all kernel versions you want this to be backported for? What ever ones you think it is relevant for :) _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k