From: Kalle Valo <kvalo@codeaurora.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: ath10k: Enable hw checksum for wcn3990
Date: Mon, 16 Apr 2018 13:16:52 +0000 (UTC) [thread overview]
Message-ID: <20180416131652.CF47560863@smtp.codeaurora.org> (raw)
In-Reply-To: <1522993544-15279-1-git-send-email-pillair@codeaurora.org>
Rakesh Pillai <pillair@codeaurora.org> wrote:
> By default ath10k driver enables the support for HW_CHECKSUM
> (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled
> in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets
> and all patckets are dropped. But due note that wcn3990 support in
> ath10k is still incomplete so this isn't a critical fix (yet).
>
> Enable hw checksum calculations in wcn3990 hardware by
> setting the proper flags in msdu descriptor tso flags.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Introduces a new sparse warning:
potku:~/ath10k/src/ath$ ath10k-check
drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: warning: invalid assignment: |=
drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: left side has type restricted __le32
drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: right side has type unsigned long
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10325669/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-04-16 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 5:45 [PATCH] ath10k: Enable hw checksum for wcn3990 pillair
2018-04-16 13:16 ` Kalle Valo [this message]
[not found] ` <20180416131652.E274C606AC@smtp.codeaurora.org>
2018-04-17 9:27 ` pillair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416131652.CF47560863@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox