From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f84ef-0003Vf-WF for ath10k@lists.infradead.org; Mon, 16 Apr 2018 13:58:51 +0000 MIME-Version: 1.0 Subject: Re: [v2] ath10k: Convert wow pattern from 802.3 to 802.11 From: Kalle Valo In-Reply-To: <1523507057-20650-1-git-send-email-wgong@codeaurora.org> References: <1523507057-20650-1-git-send-email-wgong@codeaurora.org> Message-Id: <20180416135839.8C01160807@smtp.codeaurora.org> Date: Mon, 16 Apr 2018 13:58:39 +0000 (UTC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Wen Gong wrote: > When trying to set wow wakeup patterns it fails with this command: > > iw phyxx wowlan enable patterns offset xx+ IP address xx.xx.xx.xx > > The reason is that the wow pattern from upper layer is in 802.3 format > for this case, it need to convert it to 802.11 format. The input > offset parameter is used for 802.3, but the actual offset firmware > need depends on rx_decap_mode, so that it needs to be recalculated. > Pattern of 802.3 packet is not same with 802.11 packet. If the > rx_decap_mode is ATH10K_HW_TXRX_NATIVE_WIFI, then firmware will > receive data packet with 802.11 format from hardware. > > Tested with QCA6174 hw3.0 with firmware > WLAN.RM.4.4.1-00099-QCARMSWPZ-1, but this will also affect QCA9377. > This has always failed, so it's not a regression with new firmware > releases. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo This added a new checkpatch warning: drivers/net/wireless/ath/ath10k/wow.c:228: Missing a blank line after declarations I fixed it in the pending branch. -- https://patchwork.kernel.org/patch/10337877/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k