ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: srirrama@codeaurora.org
Cc: ath10k@lists.infradead.org
Subject: [bug report] ath10k: add support for configuring management packet rate
Date: Wed, 10 Oct 2018 14:00:16 +0300	[thread overview]
Message-ID: <20181010110016.GA20491@mwanda> (raw)

Hello Sriram R,

The patch f279294e9ee2: "ath10k: add support for configuring
management packet rate" from Sep 10, 2018, leads to the following
static checker warning:

	drivers/net/wireless/ath/ath10k/mac.c:5685 ath10k_bss_info_changed()
	warn: inconsistent indenting

drivers/net/wireless/ath/ath10k/mac.c
  5673                  if (ret)
  5674                          ath10k_warn(ar,
  5675                                      "failed to set bcast rate on vdev %i: %d\n",
  5676                                      arvif->vdev_id,  ret);
  5677          }
  5678  
  5679          if (changed & BSS_CHANGED_BASIC_RATES) {
                                                       ^
Start

  5680                  if (WARN_ON(ath10k_mac_vif_chan(vif, &def))) {
  5681                          mutex_unlock(&ar->conf_mutex);
  5682                          return;
  5683                  }
  5684  
  5685          sband = ar->hw->wiphy->bands[def.chan->band];
  5686          basic_rate_idx = ffs(vif->bss_conf.basic_rates) - 1;
  5687          bitrate = sband->bitrates[basic_rate_idx].bitrate;
  5688  
  5689          hw_rate_code = ath10k_mac_get_rate_hw_value(bitrate);
  5690          if (hw_rate_code < 0) {
  5691                  ath10k_warn(ar, "bitrate not supported %d\n", bitrate);
  5692                  mutex_unlock(&ar->conf_mutex);
  5693                  return;
  5694          }
  5695  
  5696          vdev_param = ar->wmi.vdev_param->mgmt_rate;
  5697          ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param,
  5698                                          hw_rate_code);
  5699          if (ret)
  5700                  ath10k_warn(ar, "failed to set mgmt tx rate %d\n", ret);
  5701          }
                ^
End.  Looks like a bug.

  5702  
  5703          mutex_unlock(&ar->conf_mutex);
  5704  }

regards,
dan carpenter

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

             reply	other threads:[~2018-10-10 11:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 11:00 Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-10 10:49 [bug report] ath10k: add support for configuring management packet rate Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010110016.GA20491@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=ath10k@lists.infradead.org \
    --cc=srirrama@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox