From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-cys01nam02on060f.outbound.protection.outlook.com ([2a01:111:f400:fe45::60f] helo=NAM02-CY1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gKOTZ-0000qM-Eo for ath10k@lists.infradead.org; Wed, 07 Nov 2018 14:06:37 +0000 From: Sergey Matyukevich Subject: Re: [PATCH 1/4] New netlink command for TID specific configuration Date: Wed, 7 Nov 2018 14:05:58 +0000 Message-ID: <20181107140552.zfuusbapgqjumoln@bars> References: <1540230918-27712-1-git-send-email-tamizhr@codeaurora.org> <1540230918-27712-2-git-send-email-tamizhr@codeaurora.org> In-Reply-To: <1540230918-27712-2-git-send-email-tamizhr@codeaurora.org> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Tamizh chelvam Cc: "johannes@sipsolutions.net" , "linux-wireless@vger.kernel.org" , Vasanthakumar Thiagarajan , "ath10k@lists.infradead.org" Hello Tamizh, > Co-Developed-by: Tamizh Chelvam > Signed-off-by: Vasanthakumar Thiagarajan > Signed-off-by: Tamizh chelvam > --- > include/net/cfg80211.h | 14 +++++++ > include/uapi/linux/nl80211.h | 69 +++++++++++++++++++++++++++++++++ > net/wireless/nl80211.c | 86 ++++++++++++++++++++++++++++++++++++++++++ > net/wireless/rdev-ops.h | 15 ++++++++ > net/wireless/trace.h | 27 +++++++++++++ > 5 files changed, 211 insertions(+) ... > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index d744388..d386ad7 100644 > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c ... > +static int nl80211_set_tid_config(struct sk_buff *skb, > + struct genl_info *info) > +{ > + struct cfg80211_registered_device *rdev = info->user_ptr[0]; > + struct nlattr *attrs[NL80211_ATTR_TID_MAX + 1]; > + struct nlattr *tid; > + struct net_device *dev = info->user_ptr[1]; > + const char *peer = NULL; > + u8 tid_no; > + int ret = -EINVAL, retry_short = -1, retry_long = -1; > + > + tid = info->attrs[NL80211_ATTR_TID_CONFIG]; > + if (!tid) > + return -EINVAL; > + > + ret = nla_parse_nested(attrs, NL80211_ATTR_TID_MAX, tid, > + nl80211_attr_tid_policy, info->extack); > + if (ret) > + return ret; > + > + if (!attrs[NL80211_ATTR_TID]) > + return -EINVAL; > + > + if (attrs[NL80211_ATTR_TID_RETRY_SHORT]) { > + retry_short = nla_get_u8(attrs[NL80211_ATTR_TID_RETRY_SHORT]); > + if (!retry_short || > + retry_short > rdev->wiphy.max_data_retry_count) > + return -EINVAL; > + } > + > + if (attrs[NL80211_ATTR_TID_RETRY_LONG]) { > + retry_long = nla_get_u8(attrs[NL80211_ATTR_TID_RETRY_LONG]); > + if (!retry_long || > + retry_long > rdev->wiphy.max_data_retry_count) > + return -EINVAL; > + } > + > + tid_no = nla_get_u8(attrs[NL80211_ATTR_TID]); > + if (tid_no >= IEEE80211_FIRST_TSPEC_TSID) > + return -EINVAL; > + > + if (info->attrs[NL80211_ATTR_MAC]) > + peer = nla_data(info->attrs[NL80211_ATTR_MAC]); > + > + if (nla_get_flag(attrs[NL80211_ATTR_TID_RETRY_CONFIG])) { Do we really need this additional flag to indicate retry data ? Maybe we can simply check retry attrs or even retry data, e.g.: if (attrs[NL80211_ATTR_TID_RETRY_LONG] || attrs[NL80211_ATTR_TID_RETRY_SHORT]) { ... if ((retry_short > 0) || (retry_long > 0)) { ... > + if (!wiphy_ext_feature_isset( > + &rdev->wiphy, > + NL80211_EXT_FEATURE_PER_TID_RETRY_CONFIG)) > + return -EOPNOTSUPP; > + > + if (peer && !wiphy_ext_feature_isset( > + &rdev->wiphy, > + NL80211_EXT_FEATURE_PER_STA_RETRY_CONFIG)) > + return -EOPNOTSUPP; > + > + if (!rdev->ops->set_data_retry_count || > + !rdev->wiphy.max_data_retry_count) > + return -EOPNOTSUPP; > + > + ret = rdev_set_data_retry_count(rdev, dev, peer, tid_no, > + retry_short, retry_long); > + } > + > + return ret; > +} Regards, Sergey _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k