From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gqp7s-0004Wv-GF for ath10k@lists.infradead.org; Tue, 05 Feb 2019 01:02:14 +0000 Received: by mail-pg1-x543.google.com with SMTP id z11so715638pgu.0 for ; Mon, 04 Feb 2019 17:02:12 -0800 (PST) Date: Mon, 4 Feb 2019 17:02:08 -0800 From: Brian Norris Subject: Re: [PATCH] ath10k: Enable Factory Test Mode for WCN3990 Message-ID: <20190205010207.GA219734@google.com> References: <1535526038-4299-1-git-send-email-pillair@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1535526038-4299-1-git-send-email-pillair@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rakesh Pillai Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On Wed, Aug 29, 2018 at 12:30:38PM +0530, Rakesh Pillai wrote: > The support to put WCN3990 firmware into Factory > test mode is not present currently. The WCN3990 > firmware can operate in Factory test mode based > on the mode it receives in the wlan enable message > from the host driver. > > When the host driver is started in testmode send > the operating mode as UTF mode, to the WCN3990 > firmware, in the wlan enable message to start the > firmware in Factory test mode. > > Tested on: WCN3990 > Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1. > > Signed-off-by: Rakesh Pillai > --- > drivers/net/wireless/ath/ath10k/ahb.c | 3 ++- > drivers/net/wireless/ath/ath10k/core.c | 2 +- > drivers/net/wireless/ath/ath10k/hif.h | 7 ++++--- > drivers/net/wireless/ath/ath10k/mac.c | 2 +- > drivers/net/wireless/ath/ath10k/pci.c | 3 ++- > drivers/net/wireless/ath/ath10k/sdio.c | 3 ++- > drivers/net/wireless/ath/ath10k/snoc.c | 20 ++++++++++++++++---- > drivers/net/wireless/ath/ath10k/testmode.c | 2 +- > drivers/net/wireless/ath/ath10k/usb.c | 3 ++- > 9 files changed, 31 insertions(+), 14 deletions(-) What ever happened here? I'm told this is useful, but I see no comments and it's marked Deferred in patchwork: https://patchwork.kernel.org/patch/10579559/ FWIW, it looks OK to me: Reviewed-by: Brian Norris _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k