From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURkq-0008Dd-Bn for ath10k@lists.infradead.org; Tue, 12 Nov 2019 08:42:29 +0000 Received: by mail-wr1-x444.google.com with SMTP id w9so10707495wrr.0 for ; Tue, 12 Nov 2019 00:42:27 -0800 (PST) Date: Tue, 12 Nov 2019 09:42:25 +0100 From: Simon Horman Subject: Re: [PATCH] ath10k: Fix qmi init error handling Message-ID: <20191112084225.casuncbo7z54vu4g@netronome.com> References: <20191106231650.1580-1-jeffrey.l.hugo@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191106231650.1580-1-jeffrey.l.hugo@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Jeffrey Hugo Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-arm-msm@vger.kernel.org, davem@davemloft.net, kvalo@codeaurora.org On Wed, Nov 06, 2019 at 03:16:50PM -0800, Jeffrey Hugo wrote: > When ath10k_qmi_init() fails, the error handling does not free the irq > resources, which causes an issue if we EPROBE_DEFER as we'll attempt to > (re-)register irqs which are already registered. > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > Signed-off-by: Jeffrey Hugo > --- > drivers/net/wireless/ath/ath10k/snoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > index fc15a0037f0e..f2a0b7aaad3b 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -1729,7 +1729,7 @@ static int ath10k_snoc_probe(struct platform_device *pdev) > ret = ath10k_qmi_init(ar, msa_size); > if (ret) { > ath10k_warn(ar, "failed to register wlfw qmi client: %d\n", ret); > - goto err_core_destroy; > + goto err_free_irq; > } >From a casual examination of the code this seems like a step in the right direction. But does this error path also need to call ath10k_hw_power_off() ? > > ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc probe\n"); > -- > 2.17.1 > _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k