From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV1c0-0007A6-3h for ath10k@lists.infradead.org; Wed, 13 Nov 2019 22:59:45 +0000 Received: by mail-pf1-x442.google.com with SMTP id n13so2695922pff.1 for ; Wed, 13 Nov 2019 14:59:42 -0800 (PST) Date: Wed, 13 Nov 2019 14:59:38 -0800 From: Bjorn Andersson Subject: Re: [PATCH] ath10k: Handle when FW doesn't support QMI_WLFW_HOST_CAP_REQ_V01 Message-ID: <20191113225938.GA3727453@builder> References: <20191106233130.2169-1-jeffrey.l.hugo@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191106233130.2169-1-jeffrey.l.hugo@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Jeffrey Hugo Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-arm-msm@vger.kernel.org, davem@davemloft.net, kvalo@codeaurora.org On Wed 06 Nov 15:31 PST 2019, Jeffrey Hugo wrote: > Firmware with the build id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.2-XXXX does > not support the QMI_WLFW_HOST_CAP_REQ_V01 message and will return the > QMI not supported error to the ath10k driver. Since not supporting this > message is not fatal to the firmware nor the ath10k driver, lets catch > this particular scenario and ignore it so that we can still bring up > wifi services successfully. > Reviewed-by: Bjorn Andersson > Signed-off-by: Jeffrey Hugo > --- > drivers/net/wireless/ath/ath10k/qmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c > index 545ac1f06997..eb618a2652db 100644 > --- a/drivers/net/wireless/ath/ath10k/qmi.c > +++ b/drivers/net/wireless/ath/ath10k/qmi.c > @@ -614,7 +614,9 @@ static int ath10k_qmi_host_cap_send_sync(struct ath10k_qmi *qmi) > if (ret < 0) > goto out; > > - if (resp.resp.result != QMI_RESULT_SUCCESS_V01) { > + /* older FW didn't support this request, which is not fatal */ > + if (resp.resp.result != QMI_RESULT_SUCCESS_V01 && > + resp.resp.error != QMI_ERR_NOT_SUPPORTED_V01) { > ath10k_err(ar, "host capability request rejected: %d\n", resp.resp.error); > ret = -EINVAL; > goto out; > -- > 2.17.1 > _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k