ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: ath10k@lists.infradead.org, James Prestwood <prestwoj@gmail.com>
Subject: [RFC 0/1] wifi: ath10k: improvement on key removal failure
Date: Wed, 14 Aug 2024 09:45:06 -0700	[thread overview]
Message-ID: <20240814164507.996303-1-prestwoj@gmail.com> (raw)

This is in regard to my earlier question [1]. After some testing with
adding an artificial 3 second delay between auth and assoc frames I
saw that the device would fail to roam 100% of the time. This further
backed up my theory that this firmware failure is causing some
timeout on the AP, and resulting it either ignoring the reassociation
or rejecting it.

Changing kernel behavior to fix a vendor quirk isn't great, but
in this situation since the key removal is non-fatal and it
improves general performance when the firmware does time out I
thought it was an acceptable compromise. I am also pursuing the
vendor to fix this, and allow a greater delay between auth and
assoc.

The reason I'm sending this as an RFC is that I have no idea about
other hardware, firmwares, etc, that use ath10k. I have only tested
on the QCA6174. Maybe different configurations _do_ need 3 seconds
to remove a key? Maybe this timeout needs to be a hw_param?

[1] https://lore.kernel.org/linux-wireless/9eafac85-2262-4f92-a70b-32109f65c05a@gmail.com/T/#t



James Prestwood (1):
  wifi: ath10k: reduce timeout for disabling a key

 drivers/net/wireless/ath/ath10k/mac.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.34.1



             reply	other threads:[~2024-08-14 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 16:45 James Prestwood [this message]
2024-08-14 16:45 ` [RFC 1/1] wifi: ath10k: reduce timeout for disabling a key James Prestwood
2024-08-17  0:53 ` [RFC 0/1] wifi: ath10k: improvement on key removal failure Felix Kaechele
2024-08-19 11:49   ` James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814164507.996303-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox