ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Jeff Johnson <jjohnson@kernel.org>,
	 Loic Poulain <loic.poulain@linaro.org>,
	 Brian Norris <briannorris@chromium.org>,
	 Francesco Dolcini <francesco@dolcini.it>,
	 Tony Nguyen <anthony.l.nguyen@intel.com>,
	 Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	 Tariq Toukan <tariqt@nvidia.com>
Cc: ath10k@lists.infradead.org, linux-kernel@vger.kernel.org,
	ath11k@lists.infradead.org, ath12k@lists.infradead.org,
	wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH net-next 4/7] wifi: wcn36xx: Don't use %pK through printk
Date: Mon, 14 Apr 2025 10:26:05 +0200	[thread overview]
Message-ID: <20250414-restricted-pointers-net-v1-4-12af0ce46cdd@linutronix.de> (raw)
In-Reply-To: <20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de>

In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping looks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.
There are still a few users of %pK left, but these use it through seq_file,
for which its usage is safe.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wireless/ath/wcn36xx/testmode.c
index e5142c052985ddf629b93d7b9687e6ba63a48e8b..d7a2a483cbc486308032709a99bba9a52ed0ff59 100644
--- a/drivers/net/wireless/ath/wcn36xx/testmode.c
+++ b/drivers/net/wireless/ath/wcn36xx/testmode.c
@@ -56,7 +56,7 @@ static int wcn36xx_tm_cmd_ptt(struct wcn36xx *wcn, struct ieee80211_vif *vif,
 	msg = buf;
 
 	wcn36xx_dbg(WCN36XX_DBG_TESTMODE,
-		    "testmode cmd wmi msg_id 0x%04X msg_len %d buf %pK buf_len %d\n",
+		    "testmode cmd wmi msg_id 0x%04X msg_len %d buf %p buf_len %d\n",
 		   msg->msg_id, msg->msg_body_length,
 		   buf, buf_len);
 

-- 
2.49.0



  parent reply	other threads:[~2025-04-14  8:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14  8:26 [PATCH net-next 0/7] net: Don't use %pK through printk Thomas Weißschuh
2025-04-14  8:26 ` [PATCH net-next 1/7] wifi: ath10k: " Thomas Weißschuh
2025-04-14 16:16   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14  8:26 ` [PATCH net-next 2/7] wifi: ath11k: " Thomas Weißschuh
2025-04-14 16:17   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14  8:26 ` [PATCH net-next 3/7] wifi: ath12k: " Thomas Weißschuh
2025-04-14 16:16   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14  8:26 ` Thomas Weißschuh [this message]
2025-04-14 19:04   ` [PATCH net-next 4/7] wifi: wcn36xx: " Loic Poulain
2025-04-14  8:26 ` [PATCH net-next 5/7] wifi: mwifiex: " Thomas Weißschuh
2025-04-14 16:15   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14  8:26 ` [PATCH net-next 6/7] ice: Don't use %pK through printk or tracepoints Thomas Weißschuh
2025-04-14  9:59   ` Przemek Kitszel
2025-04-14 16:18   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14  8:26 ` [PATCH net-next 7/7] net/mlx5: Don't use %pK through tracepoints Thomas Weißschuh
2025-04-14 10:49   ` Tariq Toukan
2025-04-14 16:17   ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14 15:02 ` [PATCH net-next 0/7] net: Don't use %pK through printk Jeff Johnson
2025-04-15  6:42   ` Thomas Weißschuh
2025-04-14 16:17 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-04-14 18:44 ` Brian Norris
2025-04-15  6:59   ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250414-restricted-pointers-net-v1-4-12af0ce46cdd@linutronix.de \
    --to=thomas.weissschuh@linutronix.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=briannorris@chromium.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=francesco@dolcini.it \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jjohnson@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).