From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: Sven Eckelmann <sven@narfation.org>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: support for multicast rate control
Date: Wed, 9 May 2018 08:57:15 +0200 [thread overview]
Message-ID: <28391873-c8f4-4ca0-7bdd-ef4b2b1eccab@dd-wrt.com> (raw)
In-Reply-To: <17746151.BaBsPhhV2q@bentobox>
Am 09.05.2018 um 08:15 schrieb Sven Eckelmann:
> On Montag, 7. Mai 2018 18:34:51 CEST Pradeep Kumar Chitrapu wrote:
>> Issues wmi command to firmwre when multicast rate change is received
>> with the new BSS_CHANGED_MCAST_RATE flag.
>> Also fixes the incorrect fixed_rate setting for CCK rates which got
>> introduced with addition of ath10k_rates_rev2 enum.
>>
>> Tested on QCA9984 with firmware ver 10.4-3.6-00104
>>
>> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
>> ---
>> v2:
>> - fixed the CCK rates setting for mcast_rate and fixed_rate paths.
>> - set broadcast rate along with multicast rate setting.
> These things are only modified in ath10k_bss_info_changed and not saved/
> restored. What happens when the HW needs to be reset (there are are couple of
> firmware crashes which can be seen in the wild and are handled by ath10k)? I
> would guess that not all of them automatically cause an .bss_info_changed.
>
i have never seen a card properly recovering after a firmware crash, all
firmware crashes i have seen
are caused by bugs in firmware handling or the firmware itself. so if it
recovers it crashes immediatly again
ending in a endless crashloop since the cause for the crash hasnt been
fixed. they are often triggered by extern clients for instance which
still remain in the field.
i think firmware crashes should not be hidden by recovering. this would
also force users to report problems more frequently, than they do
since they dont even take notice of such problems
Sebastian
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-05-09 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cebad8674a69761e32a1a882de9a1259657c65d4>
2018-05-08 1:34 ` [PATCH v2] ath10k: support for multicast rate control Pradeep Kumar Chitrapu
2018-05-09 6:15 ` Sven Eckelmann
2018-05-09 6:57 ` Sebastian Gottschall [this message]
2018-05-09 14:31 ` Ben Greear
2018-05-10 2:46 ` pradeepc
2018-06-14 14:46 ` [v2] " Kalle Valo
2018-07-30 17:47 ` [PATCH v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28391873-c8f4-4ca0-7bdd-ef4b2b1eccab@dd-wrt.com \
--to=s.gottschall@dd-wrt.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox