From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Todd Brandt <todd.e.brandt@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
ath10k@lists.infradead.org, Linux PM <linux-pm@vger.kernel.org>
Subject: [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume
Date: Fri, 01 Mar 2019 13:51:54 +0100 [thread overview]
Message-ID: <3687330.FyvvPAkb64@aspire.rjw.lan> (raw)
rom: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ath10k_mac_vif_chan() always returns an error for the given vif
during system-wide resume which reliably triggers two WARN_ON()s
in ath10k_bss_info_changed() and they are not particularly
useful in that code path, so drop them.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-pm/drivers/net/wireless/ath/ath10k/mac.c
===================================================================
--- linux-pm.orig/drivers/net/wireless/ath/ath10k/mac.c
+++ linux-pm/drivers/net/wireless/ath/ath10k/mac.c
@@ -5705,7 +5705,7 @@ static void ath10k_bss_info_changed(stru
}
if (changed & BSS_CHANGED_MCAST_RATE &&
- !WARN_ON(ath10k_mac_vif_chan(arvif->vif, &def))) {
+ !ath10k_mac_vif_chan(arvif->vif, &def)) {
band = def.chan->band;
rateidx = vif->bss_conf.mcast_rate[band] - 1;
@@ -5743,7 +5743,7 @@ static void ath10k_bss_info_changed(stru
}
if (changed & BSS_CHANGED_BASIC_RATES) {
- if (WARN_ON(ath10k_mac_vif_chan(vif, &def))) {
+ if (ath10k_mac_vif_chan(vif, &def)) {
mutex_unlock(&ar->conf_mutex);
return;
}
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2019-03-01 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 12:51 Rafael J. Wysocki [this message]
2019-03-01 13:45 ` [PATCH] ath10k: Drop WARN_ON()s that always trigger during system resume Kalle Valo
2019-03-03 17:24 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2019-03-03 17:24 Rafael J. Wysocki
2019-04-03 19:57 ` Brian Norris
2019-04-03 21:44 ` Rafael J. Wysocki
2019-04-03 21:54 ` Brian Norris
2019-04-04 4:06 ` Kalle Valo
2019-04-04 8:28 ` Rafael J. Wysocki
2019-04-26 7:18 ` Kalle Valo
2019-04-29 8:48 ` Rafael J. Wysocki
2019-04-29 10:41 ` Claire Chang
2019-04-29 14:12 ` Kalle Valo
2019-04-29 14:10 ` Kalle Valo
2019-04-29 14:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3687330.FyvvPAkb64@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-pm@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox