From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0156.hostedemail.com ([216.40.44.156] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfdq8-0006vc-PC for ath10k@lists.infradead.org; Tue, 25 Jun 2019 05:17:59 +0000 Message-ID: <45177fdaff2bf2a2538e34dab175488d2ba9a46c.camel@perches.com> Subject: Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags From: Joe Perches Date: Mon, 24 Jun 2019 22:17:40 -0700 In-Reply-To: <746098160c4ff6527d573d2af23c403b6d4e5b80.camel@d-silva.org> References: <20190625031726.12173-1-alastair@au1.ibm.com> <20190625031726.12173-5-alastair@au1.ibm.com> <3340b520a57e00a483eae170be97316c8d18c22c.camel@perches.com> <746098160c4ff6527d573d2af23c403b6d4e5b80.camel@d-silva.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Alastair D'Silva Cc: linux-fbdev@vger.kernel.org, Stanislaw Gruszka , Petr Mladek , David Airlie , Joonas Lahtinen , dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, Jassi Brar , ath10k@lists.infradead.org, intel-gfx@lists.freedesktop.org, Dan Carpenter , Jose Abreu , Tom Lendacky , "James E.J. Bottomley" , Jani Nikula , linux-fsdevel@vger.kernel.org, Steven Rostedt , Rodrigo Vivi , Benson Leung , Kalle Valo , Karsten Keil , "Martin K. Petersen" , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , David Laight , Daniel Vetter , netdev@vger.kernel.org, Enric Balletbo i Serra , Andrew Morton , "David S. Miller" , Alexander Viro On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > In order to support additional features, rename hex_dump_to_buffer > > > to > > > hex_dump_to_buffer_ext, and replace the ascii bool parameter with > > > flags. > > [] > > > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c > > > b/drivers/gpu/drm/i915/intel_engine_cs.c > > [] > > > @@ -1338,9 +1338,8 @@ static void hexdump(struct drm_printer *m, > > > const void *buf, size_t len) > > > } > > > > > > WARN_ON_ONCE(hex_dump_to_buffer(buf + pos, len - pos, > > > - rowsize, sizeof(u32), > > > - line, sizeof(line), > > > - false) >= > > > sizeof(line)); > > > + rowsize, sizeof(u32), > > > line, > > > + sizeof(line)) >= > > > sizeof(line)); > > > > Huh? Why do this? [] > The change actions Jani's suggestion: > https://lkml.org/lkml/2019/6/20/343 I think you need to read this change again. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k