From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJzX1-0003M8-N2 for ath10k@lists.infradead.org; Tue, 06 Nov 2018 11:28:29 +0000 Message-ID: <50876f6067d109116a841399006aee950d9a2117.camel@sipsolutions.net> Subject: Re: [PATCH 0/4] cfg80211/mac80211: Add support for TID specific configuration From: Johannes Berg Date: Tue, 06 Nov 2018 12:28:11 +0100 In-Reply-To: <20181106104547.5mnbymn4peuhgng3@bars> References: <1540230918-27712-1-git-send-email-tamizhr@codeaurora.org> <20181106104547.5mnbymn4peuhgng3@bars> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sergey Matyukevich Cc: Igor Mitsyanko , Ben Greear , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" , Tamizh chelvam Hi, On Tue, 2018-11-06 at 10:45 +0000, Sergey Matyukevich wrote: > > On Mon, 2018-10-22 at 23:25 +0530, Tamizh chelvam wrote: > > > Add infrastructure for per TID aggregation/retry count configurations > > > such as retry count and AMPDU aggregation control(disable/enable). > > > In some scenario reducing the number of retry count for a specific data > > > traffic can reduce the latency by proceeding with the next packet > > > instead of retrying the same packet more time. This will be useful > > > where the next packet can resume the operation without an issue. > > > > Not sure I understand this, how can you expect to control something on a > > per-packet basis using this? > > > > Sergey, looks like your A-MPDU control is already in here per RA/TID, > > and A-MSDU could be added easily? > Thanks for pointing me at this patch series. Indeed, it looks like an > exact match for proper RA/TID aware implementation of AMPDU control. > AMSDU can be added following the same approach. > Great. I guess if you could take a look that'd be nice, and perhaps also see if you could actually implement it? Your driver patch seemed to imply the firmware only has global control, rather than per RA/TID. Also, do you think A-MPDU length control would be something useful? Perhaps that should be instead of enable/disable (since setting length to 0 or 1 could easily mean "no A-MPDU") johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k