From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fix un-initialized debug objects.
Date: Fri, 25 Oct 2013 07:59:46 -0700 [thread overview]
Message-ID: <526A8762.9050009@candelatech.com> (raw)
In-Reply-To: <871u39iydt.fsf@kamboji.qca.qualcomm.com>
On 10/25/2013 12:49 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>> INIT_WORK(&ar->restart_work, ath10k_core_restart);
>>
>> + ath10k_debug_init(ar);
>
> For symmetry would it make more sense to move ath10k_debug_destroy() to
> ath10k_core_unregister()? That way we could avoid adding a new function.
>
In my opinion, you should initialize such things as early as possible
so you don't have to worry so much about the various error cases leaving
things un-initialized. I believe my patch accomplished that.
What new function are you planning to avoid?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2013-10-25 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 18:26 [PATCH] ath10k: Fix un-initialized debug objects greearb
2013-10-25 7:49 ` Kalle Valo
2013-10-25 14:59 ` Ben Greear [this message]
2013-10-26 3:58 ` Kalle Valo
2013-10-26 4:35 ` Ben Greear
2013-10-28 10:10 ` Kalle Valo
2013-10-28 16:43 ` Ben Greear
-- strict thread matches above, loose matches on Subject: below --
2013-11-04 17:18 greearb
2013-11-08 9:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A8762.9050009@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox