From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures.
Date: Mon, 11 Nov 2013 08:55:59 -0800 [thread overview]
Message-ID: <52810C1F.3060600@candelatech.com> (raw)
In-Reply-To: <87d2m7b8qj.fsf@kamboji.qca.qualcomm.com>
On 11/11/2013 01:14 AM, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>> On 11/08/2013 01:58 AM, Kalle Valo wrote:
>>> greearb@candelatech.com writes:
>>>
>>>> From: Ben Greear <greearb@candelatech.com>
>>>>
>>>
>>> I did some changes to this patch:
>>>
>>> https://github.com/kvalo/ath/commit/20c062b93a1addc863d15334dd1eb5892a759f78
>>>
>>> The patch is still on ath-next-test branch. Please take a look and if
>>> it's ok for you, send you S-o-b tag so that I can apply it (it was
>>> missing).
>>
>> This part has some grammar issues, it seems to say that the failure
>> is due to changed bssid. Maybe make it instead:
>>
>> Failed to add peer %pM for vdev %d when changing bssid, error: %i
>>
>> - ath10k_warn("Failed to add peer: %pM for VDEV: %d\n",
>> - info->bssid, arvif->vdev_id);
>> + ath10k_warn("Failed to add peer %pM for vdev %d due to changed bssid: %i\n",
>> + info->bssid, arvif->vdev_id, ret);
>>
>> Either way, it's better than what was there before, so:
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> Good point, thanks. I just didn't use the word error as I thought that
> wasn't necessary. New version which I'll apply soon:
>
> https://github.com/kvalo/ath/commit/ee309046323f2af1d2cd6f5c1361a6ce8dae5f87
>
Looks good.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2013-11-11 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 17:19 [PATCH] ath10k: Add logging to better determine some VIF/STA creation failures greearb
2013-11-08 9:58 ` Kalle Valo
2013-11-08 16:53 ` Ben Greear
2013-11-11 9:14 ` Kalle Valo
2013-11-11 16:55 ` Ben Greear [this message]
2013-11-12 17:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52810C1F.3060600@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox