ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/1] ath10k:  add helper method to grab debug stats.
Date: Wed, 02 Apr 2014 07:57:47 -0700	[thread overview]
Message-ID: <533C256B.9090209@candelatech.com> (raw)
In-Reply-To: <8738hwrxso.fsf@kamboji.qca.qualcomm.com>

On 04/02/2014 12:32 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> It can be nice to update the firmware's stats while
>> debugging other bits of the driver, so add helper method
>> to do this.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/debug.h
>> +++ b/drivers/net/wireless/ath/ath10k/debug.h
>> @@ -135,4 +135,6 @@ struct dbglog_hdr_s {
>>
>>   void ath10k_dbg_print_fw_dbg_buffer(u8 *buffer, int len, const char* lvl);
>>
>> +int ath10k_refresh_peer_stats(struct ath10k *ar);
>
> I don't see anyone calling this. How are you planning to use it?


The RFC patch that debugs tx-hang calls it..nice to see he firmware's
buffer reap stats and such before/after trying to flush the buffers.

I figure it will be useful for other such uses as well, now that stats
actually work.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2014-04-02 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 17:55 [PATCH 1/1] ath10k: add helper method to grab debug stats greearb
2014-04-02  7:32 ` Kalle Valo
2014-04-02 14:57   ` Ben Greear [this message]
2014-04-05  6:17     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533C256B.9090209@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).