From: Ben Greear <greearb@candelatech.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: Any ideas on how to fix rssi?
Date: Thu, 15 May 2014 07:17:09 -0700 [thread overview]
Message-ID: <5374CC65.9010402@candelatech.com> (raw)
In-Reply-To: <CALhHN=qM=Kv+rKOyH4gDTNCfnPxTttCyF+gcLZnZP-R+Wa73JQ@mail.gmail.com>
On 05/14/2014 10:07 PM, Janusz Dziedzic wrote:
> On 15 May 2014 02:07, Ben Greear <greearb@candelatech.com> wrote:
>> On 05/14/2014 04:22 PM, Ben Greear wrote:
>>> I'm seeing incorrect signal strength when running a rate-vs-range
>>> test through an attenuator. Maybe the FIXME below is the reason?
>>>
>>> Any suggestions on what needs doing here?
>>
>> Actually, it wasn't (just?) this...the patch below makes the numbers look
>> good, but obviously there could be a better fix:
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
>> index ccbc363..f26f296 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
>> @@ -1218,8 +1218,13 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
>> mpdu_ranges = htt_rx_ind_get_mpdu_ranges(rx);
>>
>> /* Fill this once, while this is per-ppdu */
>> - rx_status->signal = ATH10K_DEFAULT_NOISE_FLOOR;
>> - rx_status->signal += rx->ppdu.combined_rssi;
>
> Seems you have old code without ath10k: fix rssi and rate reporting patch.
Yes, thanks for the suggestion. I had patches on each side of that one,
but somehow I had missed it. Will test with it today.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2014-05-15 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 23:22 Any ideas on how to fix rssi? Ben Greear
2014-05-15 0:07 ` Ben Greear
2014-05-15 5:07 ` Janusz Dziedzic
2014-05-15 14:17 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5374CC65.9010402@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox