From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wrruk-00046O-CD for ath10k@lists.infradead.org; Tue, 03 Jun 2014 16:50:18 +0000 Message-ID: <538DFCB5.2060208@candelatech.com> Date: Tue, 03 Jun 2014 09:49:57 -0700 From: Ben Greear MIME-Version: 1.0 Subject: Re: [RFC 2/4] ath10k: save firmware debug log messages. References: <1401812719-25061-1-git-send-email-greearb@candelatech.com> <1401812719-25061-2-git-send-email-greearb@candelatech.com> <1401813944.18833.6.camel@joe-AO725> In-Reply-To: <1401813944.18833.6.camel@joe-AO725> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Joe Perches Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 06/03/2014 09:45 AM, Joe Perches wrote: > On Tue, 2014-06-03 at 09:25 -0700, greearb@candelatech.com wrote: >> They may be dumped through the firmware dump debugfs >> file. > [] >> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > [] >> @@ -1084,11 +1084,14 @@ static void ath10k_wmi_event_echo(struct ath10k *ar, struct sk_buff *skb) >> >> static int ath10k_wmi_event_debug_mesg(struct ath10k *ar, struct sk_buff *skb) >> { >> + u32 *m = (u32 *)(skb->data); >> ath10k_dbg(ATH10K_DBG_WMI, "wmi event debug mesg len %d\n", >> skb->len); >> >> trace_ath10k_wmi_dbglog(skb->data, skb->len); >> >> + ath10k_dbg_save_fw_dbg_buffer(ar, (u8 *)(&(m[1])), skb->len - 4); >> + >> return 0; >> } >> > > That last line looks an overly complicated way of writing > > ath10k_dbg_save_fw_dbg_buffer(ar, skb->data + 4, skb->len - 4); > > btw: why skip the first 4 bytes? First 4 bytes is a counter meaning something like 'messages lost due to overflow', and is not really part of the debug messages. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k