ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: ath10k <ath10k@lists.infradead.org>
Subject: More issues with ath10k_flush
Date: Thu, 05 Jun 2014 11:47:44 -0700	[thread overview]
Message-ID: <5390BB50.7040600@candelatech.com> (raw)

I'm back to debugging this charmer.

Currently I see the flush fail (and take 5 seconds doing so)
fairly often when creating lots of station vifs against my firmware.

Once stations are connected, there are usually no more timeouts,
even though I might be sending/receiving 100+Mbps of traffic for hours at
a time.

By printing out the firmware stats, I see that much of the time
the hardware has accepted X packets for transmission, but has completed
X-1.  It is possible the firmware's counters are screwed up some how
or that it lost a packet, but I think it may also be possible that
the firmware is just being really slow about completing a packet
every now and then.  I have looked at the firmware in detail and
have found no way that it could actually leak tx descriptors.

So, I was thinking about changing the flush logic to try
the current flush (that just waits) for up to 1/5 of the
flush timeout, and if that fails, try telling the firmware to purge
it's tx buffers, and then wait up to 4/5ths more of the
flush timeout.

Does that sound like a reasonable approach?

Currently, my work-around is just to restart firmware
after it fails to flush for 2 tries in a row, seems
like there could be something better!

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

             reply	other threads:[~2014-06-05 18:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 18:47 Ben Greear [this message]
2014-06-05 23:37 ` More issues with ath10k_flush Ben Greear
2014-06-06  5:16   ` Michal Kazior
2014-06-06 14:49     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5390BB50.7040600@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox