ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matti Laakso <malaakso@elisanet.fi>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org
Subject: Re: fetching calibration data from flash
Date: Tue, 10 Jun 2014 10:59:24 +0200	[thread overview]
Message-ID: <5396C8EC.4090105@elisanet.fi> (raw)
In-Reply-To: <87wqcpb0w1.fsf@kamboji.qca.qualcomm.com>

On 10.06.2014 10:54, Kalle Valo wrote:
> Matti Laakso <malaakso@elisanet.fi> writes:
>
>>> a) Use platform data, like ath9k does.
>>>
>>> b) add a module option to ath10k, and let ath10k fetch the files via mtd 
>>> API.
>>>      Has the downside of requiring MTD (maybe add a config option to 
>>> disable that?),
>>>      but i like that more than the ath9k way of reading an arbitrary 
>>> memory region and
>>>      circumventing the MTD layer.
>>>
>>> Any thoughts? I can prepare a patch if needed.
>> There's yet another method: Use platform data to provide only a file
>> name and then use request_firmware to load it from a file under
>> /lib/firmware. Then it is up to the platform support code to get the
>> data there. This is used in OpenWrt by rt2x00 drivers.
> That's true. Now that you mention this, I remember that this was also
> suggested in linux-wireless list for wl1251 (a long time ago when I was
> still working on that driver). And there doesn't even need to a real
> file in the filesystem, it's possible to implement a udev script which
> does what it ever needs to feed the data to the kernel, be it reading
> from MTD partition or whatever.
>
> But why let the user name provide the file name? Why cannot it be a
> fixed name, like "cal.bin"?
>

If there are multiple WNICs each with its own calibration data?

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2014-06-10  8:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10  7:55 fetching calibration data from flash Sven Schnelle
2014-06-10  8:28 ` Kalle Valo
2014-06-10  8:32   ` Sven Schnelle
2014-06-10  8:36 ` Matti Laakso
2014-06-10  8:54   ` Kalle Valo
2014-06-10  8:59     ` Matti Laakso [this message]
2014-06-10  9:03       ` Kalle Valo
2014-06-10 15:56         ` Ben Greear
2014-06-11  8:38           ` Kalle Valo
2014-06-11 13:40             ` Ben Greear
2014-06-16 12:24               ` Kalle Valo
2014-06-16 14:53                 ` Ben Greear
2014-06-16 15:28                   ` Kalle Valo
2014-06-16 15:58                     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5396C8EC.4090105@elisanet.fi \
    --to=malaakso@elisanet.fi \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox