From: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH V3 2/2] ath10k: Fix interrupt storm
Date: Mon, 2 Mar 2015 16:32:43 +0530 [thread overview]
Message-ID: <54F44353.1090907@qti.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmLciCZ4dXbH4rO1vU32OQzNgF+cJT-tkFcOKvq00Ur1Q@mail.gmail.com>
>
>
>>>> @@ -3476,6 +3504,13 @@ static void ath10k_configure_filter(struct
>>>> ieee80211_hw *hw,
>>>>
>>>> changed_flags &= SUPPORTED_FILTERS;
>>>> *total_flags &= SUPPORTED_FILTERS;
>>>> + if (*total_flags & FIF_PROMISC_IN_BSS) {
>>>> + if (ar->num_started_vdevs) {
>>>> + ath10k_dbg(ar, ATH10K_DBG_MAC,
>>>> + "mac does not enable promiscuous mode
>>>> when already a vdev is running\n");
>>>> + *total_flags &= ~FIF_PROMISC_IN_BSS;
>>>> + }
>>>> + }
>>>
>>>
>>> There's no need for that, is there? The monitor_recalc() is supposed
>>> to deal with this.
>>
>>
>> Right, but we may not want to create any inconsistencies between
>> *total_flags and actual
>> filters enabled in the driver?.
>
> See the "DOC: Frame filtering" in include/net/mac80211.h. ath10k
> either always delivers frames IN_BSS (AP operation) or can be forced
> to (via monitor vdev for STA/IBSS operation) so FIF_PROMISC_IN_BSS
> should never be cleared.
Your are right. We should not be clearing that flag as long as we support
that functionality in one or other way. Thanks.
Vasanth
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-03-02 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 9:50 [PATCH V3 1/2] ath10k: Move ath10k_vdev_stop() up before ath10k_vdev_start_restart() Vasanthakumar Thiagarajan
2015-02-27 9:50 ` [PATCH V3 2/2] ath10k: Fix interrupt storm Vasanthakumar Thiagarajan
2015-03-02 8:43 ` Michal Kazior
[not found] ` <1425288686058.83668@qti.qualcomm.com>
2015-03-02 10:17 ` Vasanthakumar Thiagarajan
2015-03-02 10:33 ` Michal Kazior
2015-03-02 11:02 ` Vasanthakumar Thiagarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F44353.1090907@qti.qualcomm.com \
--to=vthiagar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox