From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: Bug in CCK hw_rate definitions?
Date: Tue, 29 Sep 2015 13:42:09 -0700 [thread overview]
Message-ID: <560AF7A1.7080408@candelatech.com> (raw)
In-Reply-To: <CA+BoTQ=C3v+tMoM9_-Q7iTDRy=Zx0gxxib1gxkoOaK3tYpoBvg@mail.gmail.com>
On 09/21/2015 12:32 AM, Michal Kazior wrote:
> On 15 September 2015 at 23:35, Ben Greear <greearb@candelatech.com> wrote:
>> ath10k hw.h has this:
>>
>> enum ath10k_hw_rate_cck {
>> ATH10K_HW_RATE_CCK_LP_11M = 0,
>> ATH10K_HW_RATE_CCK_LP_5_5M,
>> ATH10K_HW_RATE_CCK_LP_2M,
>> ATH10K_HW_RATE_CCK_LP_1M,
>>
>> But, at least in 10.1 firmware, it appears that CCK hw_rates are 0x40, 0x41,
>> etc
>> (For those of you with firmware, see ar600P_phy.c, 'RC' column of the rate
>> table.)
>>
>> Am I missing something or is the driver code just wrong?
>
> These macros are used only to decode L_SIG_RATE now. It can take values 0..15.
>
> If you need/want to change ath10k_hw_rate_cck you'll need to make sure
> to update ath10k_mac_hw_rate_to_idx() or its callsite accordingly.
Just to close the loop on this:
I was confused about exactly how this was being used.
In the end, I have this working to my satisfaction without having
to change the enums.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-09-29 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 21:35 Bug in CCK hw_rate definitions? Ben Greear
2015-09-21 7:32 ` Michal Kazior
2015-09-29 20:42 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560AF7A1.7080408@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).