From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: ath10k@lists.infradead.org
Subject: Re: [PATCH 1/6] ath10k: fix otp board id error message
Date: Wed, 25 Nov 2015 14:48:19 +0100 [thread overview]
Message-ID: <5655BC23.20105@dd-wrt.com> (raw)
In-Reply-To: <20151125133804.25507.64575.stgit@potku.adurom.net>
but consider to ignore the result. this code will still fail on all IPQ
SOC's with embedded QCA99XX cards.
they do not contain any valid otp and this function will always fail. so
the result must be ignored.
this problem has been seen on Linksys EA8500, Netgear R7500 and Trendnet
TEW827
so far all router based solutions using QCA99XX are affected
Am 25.11.2015 um 14:38 schrieb Kalle Valo:
> We check board id from all board types, not just qca99x0, so the error message
> was misleading.
>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index f128adbae454..78fe1863ad04 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -1753,7 +1753,7 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
>
> ret = ath10k_core_get_board_id_from_otp(ar);
> if (ret && ret != -EOPNOTSUPP) {
> - ath10k_err(ar, "failed to get board id from otp for qca99x0: %d\n",
> + ath10k_err(ar, "failed to get board id from otp: %d\n",
> ret);
> return ret;
> }
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-11-25 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:37 [PATCH 0/6] ath10k: print crc32 checksum Kalle Valo
2015-11-25 13:38 ` [PATCH 1/6] ath10k: fix otp board id error message Kalle Valo
2015-11-25 13:48 ` Sebastian Gottschall [this message]
2015-11-25 13:38 ` [PATCH 2/6] ath10k: reorganise hardware and firmware info messages Kalle Valo
2015-11-25 13:38 ` [PATCH 3/6] ath10k: always show bmi chip ids and subdevice ids Kalle Valo
2015-11-25 13:38 ` [PATCH 4/6] ath10k: split driver info messages during device initialisation Kalle Valo
2015-11-25 13:38 ` [PATCH 5/6] ath10k: print crc32 checksums for firmware and board files Kalle Valo
2015-11-25 13:38 ` [PATCH 6/6] ath10k: implement fw_checksums debugfs file Kalle Valo
2015-11-30 15:15 ` [PATCH 0/6] ath10k: print crc32 checksum Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5655BC23.20105@dd-wrt.com \
--to=s.gottschall@dd-wrt.com \
--cc=ath10k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox