From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail25.static.mailgun.info ([104.130.122.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ilnGz-0006Sp-TJ for ath10k@lists.infradead.org; Mon, 30 Dec 2019 05:07:23 +0000 MIME-Version: 1.0 Date: Mon, 30 Dec 2019 10:37:16 +0530 From: tamizhr@codeaurora.org Subject: Re: [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support In-Reply-To: <20191226185132.GA31120@bogus> References: <1576496415-23064-1-git-send-email-tamizhr@codeaurora.org> <20191226185132.GA31120@bogus> Message-ID: <62b9e7b140a96401469f7075811d0d67@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Hi Rob, Thanks for your review comments. >> This adds new dt entries qcom,coexist-support and >> qcom,coexist-gpio-pin >> which will be used by ath10k driver to identify coex support >> of a hardware and notify wifi firmware the gpio pin number. >> This pin number information is needed for the hardware QCA4019. >> >> Signed-off-by: Tamizh Chelvam >> --- >> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 6 >> ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 0171283..a41e936 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -87,6 +87,10 @@ Optional properties: >> Definition: Quirk specifying that the firmware expects the 8bit >> version >> of the host capability QMI request >> - qcom,xo-cal-data: xo cal offset to be configured in xo trim >> register. >> +- qcom,coexist-support : should contain eithr "0" or "1" to indicate >> coex >> + support by the hardware. >> +- qcom,coexist-gpio-pin : gpio pin number information to support >> coex >> + which will be used by wifi firmware. > > What combinations of these 2 properties are valid? > > Is qcom,coexist-gpio-pin required for coexist support? If so then it > alone should be enough to enable/disable coexist. > qcom,coexist-gpio-pin is required for QCA4019 devices. And other ath10k devices doesn't required that value. So only added two fields to enable/disable coexist and another for notifying the gpio pin info. >> >> Example (to supply PCI based wifi block details): >> >> @@ -156,6 +160,8 @@ wifi0: wifi@a000000 { >> qcom,msi_addr = <0x0b006040>; >> qcom,msi_base = <0x40>; >> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ]; >> + qcom,coexist-support = <1>; >> + qcom,coexist-gpio-pin = <0x33>; >> }; >> >> Example (to supply wcn3990 SoC wifi block details): >> -- Thanks, Tamizh. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k