ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Balaji Pothunoori <bpothuno@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCHv2 3/3] ath10k: average ack rssi support for data frames
Date: Wed, 05 Sep 2018 12:53:52 +0530	[thread overview]
Message-ID: <65b1a2b72d3c2a73902fe7d65754636a@codeaurora.org> (raw)
In-Reply-To: <87r2i87dke.fsf@kamboji.qca.qualcomm.com>

On 2018-09-05 10:20, Kalle Valo wrote:
> Balaji Pothunoori <bpothuno@codeaurora.org> writes:
> 
>> Average ack rssi value is weighted average of ack rssi for
>> no of msdu's has been sent.
>> This feature is enabled by the host driver if firmware is capable.
>> After receiving event from host, firmware allocates the necessary
>> memory to store the ack_rssi for data packets during the init time.
>> 
>> After each successful transmission, If tx completion status is OK
>> and 24th bit is set in HTT message header then host will fetch the
>> ack_rssi else host can ignore the ack_rssi field.
>> 
>> Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org>
> 
> There were two new warnings:
> 
> drivers/net/wireless/ath/ath10k/htt_rx.c:1928: line over 90 characters
> drivers/net/wireless/ath/ath10k/mac.c:8511: Alignment should match
> open parenthesis

In v3 i have addressed Alignment warning.

> 
> I fixed those in the pending branch. The first one I solved by adding a
> temporary variable 'msdus'. Please review:

Thanks kalle for optimizing the code , I am fine with the changes.

> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=e4ac90b9c915a3b86eeef60509a6d2bb85d3507d


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-09-05  7:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16 14:48 [PATCHv2 0/3]: cfg80211/mac80211/ath10k: average ack rssi support for data frames Balaji Pothunoori
2018-04-16 14:48 ` [PATCHv2 1/3] cfg80211: " Balaji Pothunoori
2018-04-16 14:48 ` [PATCHv2 2/3] mac80211: " Balaji Pothunoori
2018-04-16 14:48 ` [PATCHv2 3/3] ath10k: " Balaji Pothunoori
2018-05-08 15:10   ` [PATCHv2,3/3] " Kalle Valo
2018-09-05  4:50   ` [PATCHv2 3/3] " Kalle Valo
2018-09-05  7:23     ` Balaji Pothunoori [this message]
2018-09-06 16:05   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65b1a2b72d3c2a73902fe7d65754636a@codeaurora.org \
    --to=bpothuno@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox