From: Ben Greear <greearb@candelatech.com>
To: Ahmed Zaki <anzaki@gmail.com>
Cc: ath10k@lists.infradead.org
Subject: Re: WMM not working for mcast packets on ath10k
Date: Tue, 11 Aug 2020 07:01:12 -0700 [thread overview]
Message-ID: <6765404f-887d-d89e-af4a-6acca22be992@candelatech.com> (raw)
In-Reply-To: <CANczwAH0TT9oeTjLem8cZo=eLAVimeJcDCDCuV4DeySUn4zxKg@mail.gmail.com>
On 8/11/20 5:22 AM, Ahmed Zaki wrote:
> On Tue, 11 Aug 2020 at 01:05, Ben Greear <greearb@candelatech.com> wrote:
>>
>> On 8/10/20 3:08 PM, Ahmed Zaki wrote:
>>> Hello,
>>>
>>> I have 2 ath10k devices set in Mesh Point mode. When I use iptables'
>>> DSCP target to set the WMM AC for some traffic ports to VO, the rules
>>> work fine but only for unicast packets. All broadcast on the target
>>> UDP ports goes out as BE, and not VO.
>>>
>>> With some ath10k debugging enabled, it seems that the htt is indeed
>>> sending the tx descriptor with the correct tid (6) set.
>>>
>>> Is this the intended behavior for some reason? If not, is there any
>>> more debugging on the TX path that I can do?
>>
>> I don't think that WMM makes sense for bcast frames since they go out on
>> a special TID that does not do aggregation or per peer QoS settings.
>
> I get that, but we want to give some WMM priority to bcast as they tend to have
> higher probability of loss under high network loads.
>
> That special TID that you mentioned, is it set in the ath10k fw?
> Because I traced the
> htt and it is sending the intended tid in the txbuf flags, but bcast
> still come 0 (BE) on air.
> Or am I missing something in the driver?
>
> Thanks again for help.
Maybe you can convert bcast to unicast in the driver/mac80211? There are no retries
or proper rate-ctrl for bcast either, so I don't think you can get great performance
for bcast.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-08-11 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 22:08 WMM not working for mcast packets on ath10k Ahmed Zaki
2020-08-10 23:05 ` Ben Greear
2020-08-11 12:14 ` Sebastian Gottschall
2020-08-11 12:22 ` Ahmed Zaki
2020-08-11 14:01 ` Ben Greear [this message]
2020-08-11 14:36 ` Ahmed Zaki
2020-08-11 14:39 ` Ben Greear
2020-08-12 13:09 ` Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6765404f-887d-d89e-af4a-6acca22be992@candelatech.com \
--to=greearb@candelatech.com \
--cc=anzaki@gmail.com \
--cc=ath10k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox