From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/7] ath10k: remove ath10k_sdio_io()
Date: Wed, 5 Apr 2017 18:08:16 +0200 [thread overview]
Message-ID: <6a6d8e7f-ccd2-0ee6-bd99-6d82dd906843@gmail.com> (raw)
In-Reply-To: <149137591893.4898.2318291094351440261.stgit@potku.adurom.net>
I can't find patch 1/7...
On 2017-04-05 09:06, Kalle Valo wrote:
> Using ath10k_sdio_io() and ath10k_sdio_read_write_sync() are just
> confusing. Refactor the code by following the plan outlined
> below.
>
> I'm planning to fold all these seven patches into Erik's patch
> adding sdio.c[1] so I didn't write any commit logs. I'm just
> submitting these separately to make it easier to review the
> changes.
>
> Kalle
>
> ath10k_sdio_read_write_sync():
> X HIF_RD_SYNC_BLOCK_FIX -> ath10k_sdio_readsb()
> X HIF_RD_SYNC_BYTE_INC -> ath10k_sdio_read(), ath10k_sdio_read32()
> X HIF_WR_SYNC_BYTE_FIX -> ath10k_sdio_writesb32()
> X HIF_WR_SYNC_BYTE_INC -> ath10k_sdio_write()
>
> ath10k_sdio_prep_async_req():
> X HIF_WRITE -> HIF_WR_SYNC_BYTE_INC -> ath10k_sdio_write()
>
> ath10k_sdio_read/write32():
> sdio_readl()/sdio_writel() (those use endian macros)
>
> ath10k_sdio_writesb32():
> kmalloc()
> sdio_writesb(len)
> kfree()
>
> ath10k_sdio_readsb():
> len = round_down(len, ar_sdio->mbox_info.block_size);
> sdio_readsb(len)
>
> ath10k_sdio_read():
> sdio_memcpy_fromio()
>
> ath10k_sdio_write():
> sdio_memcpy_toio()
>
>
> [1] https://patchwork.kernel.org/patch/9626001/
>
> ---
>
> Kalle Valo (7):
> ath10k: add ath10k_sdio_write32/read32()
> ath10k: add ath10k_sdio_writesb()
> ath10k: add ath10k_sdio_read()
> ath10k: add ath10k_sdio_write()
> ath10k: add ath10k_sdio_readsb()
> ath10k: convert __ath10k_sdio_write_async() to use ath10k_sdio_write()
> ath10k: remove unused sdio wrappers
>
>
> drivers/net/wireless/ath/ath10k/sdio.c | 419 +++++++++++++++++---------------
> drivers/net/wireless/ath/ath10k/sdio.h | 40 ---
> 2 files changed, 219 insertions(+), 240 deletions(-)
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-04-05 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 7:06 [PATCH 0/7] ath10k: remove ath10k_sdio_io() Kalle Valo
2017-04-05 7:06 ` [PATCH 2/7] ath10k: add ath10k_sdio_writesb() Kalle Valo
2017-04-05 7:06 ` [PATCH 3/7] ath10k: add ath10k_sdio_read() Kalle Valo
2017-04-05 7:07 ` [PATCH 4/7] ath10k: add ath10k_sdio_write() Kalle Valo
2017-04-05 7:07 ` [PATCH 5/7] ath10k: add ath10k_sdio_readsb() Kalle Valo
2017-04-05 7:07 ` [PATCH 6/7] ath10k: convert __ath10k_sdio_write_async() to use ath10k_sdio_write() Kalle Valo
2017-04-05 7:07 ` [PATCH 7/7] ath10k: remove unused sdio wrappers Kalle Valo
2017-04-05 16:08 ` Erik Stromdahl [this message]
2017-04-05 16:53 ` [PATCH 0/7] ath10k: remove ath10k_sdio_io() Kalle Valo
2017-04-05 17:14 ` Erik Stromdahl
2017-04-09 18:04 ` Erik Stromdahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6d8e7f-ccd2-0ee6-bd99-6d82dd906843@gmail.com \
--to=erik.stromdahl@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox