From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable From: Johannes Berg Date: Fri, 13 Nov 2020 09:16:50 +0100 In-Reply-To: <83dd20def685d303106f285400367b6e@codeaurora.org> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> <83dd20def685d303106f285400367b6e@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: Arend Van Spriel , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org On Fri, 2020-11-13 at 16:14 +0800, Wen Gong wrote: > On 2020-11-13 15:38, Johannes Berg wrote: > > On Fri, 2020-11-13 at 10:08 +0800, Wen Gong wrote: > > > > Which was the intent of this change, wasn't it? > > > > Indeed. Permitting this leads to warnings later. > > > > > We need to set the tx rate to fixed at a single rate, e.g., > > > 54M/48M/36M... for a test case. > > > I do not want a clear error message, I want to the 54M rate pass/set > > > success to lower wlan driver. > > > Then lower wlan driver can handle it. > > > > No, that will not happen. You should configure your test AP to actually > > support 54M. > Yes, the AP support 54M, but it is not basic rate, so > ieee80211_set_bitrate_mask will reject 54M > because fail for check (mask->control[band].legacy & basic_rates). Ah. So this is what I said in the original commit message even: > Technically, selecting basic rates as the criterion is a bit too > restrictive, but calculating the usable rates over all stations > (e.g. in AP mode) is harder, and all stations must support the > basic rates. Similarly, in client mode, the basic rates will be > used anyway for control frames. I guess if we really want to redefine the user rate mask to not apply to control frames, then we can relax this? johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k