Re: [v2] ath10k-firmware: QCA4019 hw1.0: Add ZTE MF289F rev. AT1/AT2 (2.4G/5.8G) specific BDF

[Kalle Valo <kvalo@kernel.org>]

Christian Lamparter <chunkeey@gmail.com> writes:

> On 3/17/23 12:38, Kalle Valo wrote:
>> Giammarco Marzano <giammarco.marzano@gmail.com> writes:
>> 
>>> this file is for add definition for ZTE MF289F.
>>>
>>> The device is currently under review as PR on OpenWRT:
>>> https://github.com/openwrt/openwrt/pull/10418
>>>
>>> Please ignore my email of 3 August, this board binary add support for
>>> 5Ghz on AT2 version with correct calibration data.
>>>
>>> * description for what hardware this is:
>>>
>>>    - it is a IPQ4019 based board
>>>    - one QCA4019 radio is used as 2.4GHz radio
>>>    - one QCA4019 radio is used as 5Ghz radio in AT2 revision
>>>    - one QCA9984 radio is used as 5GHz radio in AT1 revision
>>>
>>> * origin of the board file: taken from stock firmware image
>>>
>>> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
>>>
>>>    - QCA4019 hw1.0
>>>
>>>      + bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=zte,mf289f
>>>        md5sum: 175139f44d2ae01c2b23e093d571e962
>>>      + bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=zte,mf289f
>>>        md5sum: 175139f44d2ae01c2b23e093d571e962
>>>
>>>
>>> * attach the actual board file (board.bin)
>>>
>>>    - The name of the file is equal to the first id string in the board-2.bin
>>>      (minus the ".bin")
>> Note: There was only board file attached but the text listed two.
>
> I can tell you what happen. This is thanks to the following OpenWrt
> Pull Request: <https://github.com/openwrt/openwrt/pull/13019>
>
> But back to Giammarco Marzano mail:
> His bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=zte,mf289f.bin
> contained a packed "board-2.bin". So, the board-2.bin ended up
> within the linux-firmware's board-2.bin:
>
> <https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ath10k/QCA4019/hw1.0/board-2.bin>
> See at offset 14c360. There's an QCA-ATH10K-BOARD string. I don't
> think ath10k supports board-2.bin within board-2.bin.

Yeah, board-2.bin within board-2.bin is not supported :)

> I've added the extracted the two board files within and attached
> them including the note to this mail after the === separator.
> (also fixed the md5sums)

Thanks for catching and fixing this. I should have been more careful.

> ===
>
> * description for what hardware this is:
>
>   - it is a IPQ4019 based board
>   - one QCA4019 radio is used as 2.4GHz radio
>   - one QCA4019 radio is used as 5Ghz radio in AT2 revision
>   - one QCA9984 radio is used as 5GHz radio in AT1 revision
>
> * origin of the board file: taken from stock firmware image
>
> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
>
>   - QCA4019 hw1.0
>
>     + bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=zte,mf289f
>       md5sum: f0243c9d7b45bb0ffe3e58c27e71fe80
>     + bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=zte,mf289f
>       md5sum: e0fd5376d24f0c2c3c49ba2a7fc37376
>
>
> * attach the actual board file (board.bin)
>
>   - The name of the file is equal to the first id string in the board-2.bin
>     (minus the ".bin")

Thanks, added to QCA4019/hw1.0/board-2.bin:

New:
bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=zte,mf289f

Changed:
bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=zte,mf289f

Deleted:

1 board image(s) added, 1 changed, 0 deleted, 148 in total

https://github.com/kvalo/ath10k-firmware/commit/0bf43f8decd3ae5bb9f27c3a44f54b3fa23aaa31

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k