From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "mike@fireburn.co.uk" <mike@fireburn.co.uk>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: Bug 119151 - [regression] ath10k no longer authenitcates and freezes system
Date: Fri, 3 Jun 2016 15:52:03 +0000 [thread overview]
Message-ID: <871t4ew9r1.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <57505179.8090509@candelatech.com> (Ben Greear's message of "Thu, 2 Jun 2016 08:32:09 -0700")
Ben Greear <greearb@candelatech.com> writes:
> On 06/02/2016 08:26 AM, Valo, Kalle wrote:
>> Ben Greear <greearb@candelatech.com> writes:
>>
>>> I found a lot of problems with this code as well, and the 5 patches
>>> starting from the URL below fixed the issues for me.
>>>
>>> They are stuck as 'NA' in patchwork, but I don't know why.
>>>
>>> http://lists.infradead.org/pipermail/ath10k/2016-April/007218.html
>>
>> ath10k has a separate patchwork instance, did you look at the correct
>> one? I have quite a lot of patches from you in deferred state because of
>> the patch bomb, but I'm hoping to go through them soon.
>>
>> https://patchwork.kernel.org/project/ath10k/list/?state=10&delegate=25621&order=date
>
> Ok, they are deferred then.
>
> The series of 5 is likely quite useful and fixes some nasty bugs,
> and the first patch of the big bomb is also a trivial crash fix
> for a regression you added (as best as I can tell).
>
> The rest of the patch bomb is less critical, but making some progress on
> that would make me feel good about working on ath10k patches again.
If I get a big patchset like 25 patches it immediately goes to the
bottom of the queue. Organising them a bit better takes like 15 minutes
of your time and makes it a lot easier to review. For example, you could
have split the patches into three sets: important bug fixes, firmware
debugging and the rest. That helps everyone and saves time.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-06-03 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 13:52 Bug 119151 - [regression] ath10k no longer authenitcates and freezes system Valo, Kalle
2016-06-02 14:24 ` Valo, Kalle
2016-06-02 15:21 ` Ben Greear
2016-06-02 15:26 ` Valo, Kalle
2016-06-02 15:32 ` Ben Greear
2016-06-03 15:52 ` Valo, Kalle [this message]
2016-06-03 16:12 ` Ben Greear
2016-06-02 15:34 ` Mohammed Shafi Shajakhan
2016-06-02 17:03 ` Manoharan, Rajkumar
2016-06-02 17:23 ` Ben Greear
2016-06-02 17:41 ` Rajkumar Manoharan
2016-06-02 18:02 ` Ben Greear
[not found] ` <CAHbf0-GT0y1pEs-ToxbPAf+aRo7TNAyV_Emies_rjL27R1fk2A@mail.gmail.com>
2016-06-08 15:52 ` Rajkumar Manoharan
2016-06-08 17:41 ` Mike Lothian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t4ew9r1.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mike@fireburn.co.uk \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).