ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: ath10k@lists.infradead.org, denton.gentry@gmail.com
Subject: Re: [RFT/RFC 0/5] ath10k: handle/report A-MSDU as a skb list
Date: Fri, 18 Jul 2014 15:32:18 +0300	[thread overview]
Message-ID: <871tti3l0t.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1404992714-15690-1-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Thu, 10 Jul 2014 13:45:09 +0200")

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> This is prototype, how we can handle A-MSDU as a skb list in mac80211.
> No changes in mac80211 reordering code required in such case, also we
> don't need to build one big frame using memcpy ...
>
> With such prototype tid_agg_rx->reorder_buf[sn] will describe exactly
> one MPDU (with included A-MSDU subframes if skb->next) and detection of
> duplicated frames will work correctly. So, reordering should works
> correctly.
>
> I tested this with A-MPDU and A-MSDU run together (A-MSDU frame up to
> 10k) - TCP STA -> AP. I used ath10k STA with unlocked A-MSDU limit in
> RC in firmware. Didn't notice any problems.

So what are you exactly fixing here? It would be nice to get some
background and motivations for the changes in the cover letter.

Also we have so many reordering patches that I'm confused now. For
example, how is this related to patch "ath10k: handle attention flags
correctly when A-MSDU"?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2014-07-18 12:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 11:45 [RFT/RFC 0/5] ath10k: handle/report A-MSDU as a skb list Janusz Dziedzic
2014-07-10 11:45 ` [RFT/RFC 1/5] ath10k: amsdu rx, buid one big frame Janusz Dziedzic
2014-07-10 11:45 ` [RFT/RFC 2/5] mac80211: add option to handle amsdu as a list of skb Janusz Dziedzic
2014-07-10 11:45 ` [RFT/RFC 3/5] cfg80211: allow RX amsdu to be reported as a list Janusz Dziedzic
2014-07-10 11:45 ` [RFT/RFC 4/5] ath10k: report amsdu as a skb list Janusz Dziedzic
2014-07-10 11:45 ` [RFT/RFC 5/5] ath10k: rx, don't pass frames with invalid FCS Janusz Dziedzic
2014-07-18 12:32 ` Kalle Valo [this message]
2014-07-18 12:40   ` [RFT/RFC 0/5] ath10k: handle/report A-MSDU as a skb list Janusz Dziedzic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tti3l0t.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=denton.gentry@gmail.com \
    --cc=janusz.dziedzic@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox