From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VP620-0004xm-Vp for ath10k@lists.infradead.org; Thu, 26 Sep 2013 07:30:37 +0000 From: Kalle Valo Subject: Re: [PATCH 04/11] ath: Remove extern from function prototypes References: Date: Thu, 26 Sep 2013 10:30:00 +0300 In-Reply-To: (Joe Perches's message of "Wed, 25 Sep 2013 12:37:22 -0700") Message-ID: <871u4ct4zr.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Joe Perches Cc: Jouni Malinen , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "John W. Linville" , ath10k@lists.infradead.org, "Luis R. Rodriguez" , ath9k-devel@lists.ath9k.org, "David S. Miller" , linux-kernel@vger.kernel.org Joe Perches writes: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/ath/ath10k/debug.h | 8 ++++---- > drivers/net/wireless/ath/ath6kl/common.h | 3 +-- > drivers/net/wireless/ath/ath6kl/debug.h | 9 ++++----- > drivers/net/wireless/ath/ath9k/ath9k.h | 2 +- > 4 files changed, 10 insertions(+), 12 deletions(-) For the ath10k and ath6kl changes: Acked-by: Kalle Valo -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k