From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1diEd4-000899-R5 for ath10k@lists.infradead.org; Thu, 17 Aug 2017 06:50:08 +0000 From: Kalle Valo Subject: Re: [2/6] ath10k: refactor firmware crashdump code to coredump.c Date: Thu, 17 Aug 2017 06:49:40 +0000 Message-ID: <87378q664c.fsf@kamboji.qca.qualcomm.com> References: <150278538298.22482.10986802411848917689.stgit@potku.adurom.net> In-Reply-To: (Kalle Valo's message of "Thu, 17 Aug 2017 06:20:02 +0200") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: "ath10k@lists.infradead.org" Cc: "linux-wireless@vger.kernel.org" Kalle Valo writes: > Kalle Valo wrote: > >> In preparation to add RAM dump support. No functional changes, only moving code >> and renaming function names. >> >> Signed-off-by: Kalle Valo > > With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a build error: > > drivers/net/wireless/ath/ath10k/coredump.c:24:30: error: redefinition > of 'ath10k_coredump_new' > drivers/net/wireless/ath/ath10k/coredump.c:130:5: error: redefinition > of 'ath10k_coredump_submit' Fixed in pending branch like this: --- a/drivers/net/wireless/ath/ath10k/Makefile +++ b/drivers/net/wireless/ath/ath10k/Makefile @@ -20,7 +20,7 @@ ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o ath10k_core-$(CONFIG_THERMAL) += thermal.o ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o ath10k_core-$(CONFIG_PM) += wow.o -ath10k_core-$(CONFIG_ATH10K_DEBUGFS) += coredump.o +ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k