From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
Cc: "mohammed@codeaurora.org" <mohammed@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4
Date: Wed, 23 Mar 2016 13:00:01 +0000 [thread overview]
Message-ID: <8737rhfiy7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1458132214-4896-3-git-send-email-mohammed@qca.qualcomm.com> (Mohammed Shafi Shajakhan's message of "Wed, 16 Mar 2016 18:13:34 +0530")
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:
> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> Rx duration support for per station is part of extended peer
> stats, enable provision to parse the same and provide backward
> compatibility based on the 'stats_id' event
>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
There was a new sparse warning:
drivers/net/wireless/ath/ath10k/wmi.c:2978:42: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath10k/wmi.c:2978:42: expected unsigned int [unsigned] [usertype] rx_duration
drivers/net/wireless/ath/ath10k/wmi.c:2978:42: got restricted __le32 const [usertype] rx_duration
I fixed it like this in the pending branch, please double check:
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2975,7 +2975,7 @@ static int ath10k_wmi_10_4_op_pull_fw_stats(struct ath10k *ar,
ath10k_wmi_10_4_pull_peer_stats(&src->common, dst);
/* FIXME: expose 10.4 specific values */
if (extd_peer_stats)
- dst->rx_duration = src->rx_duration;
+ dst->rx_duration = __le32_to_cpu(src->rx_duration);
list_add_tail(&dst->list, &stats->peers);
}
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-03-23 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 12:43 [PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature Mohammed Shafi Shajakhan
2016-03-16 12:43 ` [PATCH v1 2/3] ath10k: Introduce Extended Resource Config support for 10.4 Mohammed Shafi Shajakhan
2016-03-16 12:43 ` [PATCH v1 3/3] ath10k: Enable parsing per station rx duration " Mohammed Shafi Shajakhan
2016-03-23 13:00 ` Valo, Kalle [this message]
2016-03-23 13:03 ` Mohammed Shafi Shajakhan
2016-03-23 13:08 ` Shajakhan, Mohammed Shafi (Mohammed Shafi)
2016-03-24 6:51 ` Valo, Kalle
2016-03-24 7:01 ` Mohammed Shafi Shajakhan
2016-04-04 14:54 ` [PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737rhfiy7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@codeaurora.org \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox