From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAvzv-00084z-Mg for ath10k@lists.infradead.org; Wed, 05 Feb 2014 06:30:12 +0000 From: Kalle Valo Subject: Re: [PATCH 4/4] ath10k: Better tx/rx debugging. References: <1390435562-15473-1-git-send-email-greearb@candelatech.com> <1390435562-15473-4-git-send-email-greearb@candelatech.com> <87lhxqoghd.fsf@kamboji.qca.qualcomm.com> Date: Wed, 5 Feb 2014 08:29:43 +0200 In-Reply-To: (Marek Puzyniak's message of "Wed, 5 Feb 2014 07:05:08 +0100") Message-ID: <874n4enkbs.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Marek Puzyniak Cc: Janusz Dziedzic , greearb@candelatech.com, ath10k@lists.infradead.org Marek Puzyniak writes: > On 4 February 2014 19:55, Kalle Valo wrote: >> greearb@candelatech.com writes: >> >>> From: Ben Greear >>> >>> Make it easier to grep for htt rx errors. >>> >>> Signed-off-by: Ben Greear >> >> [...] >> >>> @@ -961,6 +962,7 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt, >>> } >>> >>> if (test_bit(ATH10K_CAC_RUNNING, &htt->ar->dev_flags)) { >>> + ath10k_warn("htt rx: CAC running\n"); >>> ath10k_htt_rx_free_msdu_chain(msdu_head); >>> continue; >>> } >> >> I'm a bit worried about this one. Do we guarantee that we will never >> receive frames while CAC is running? In other words, is this a normal >> event or really an error in the driver which requires a warning >> message? > > Actually this happens quite often during CAC. I remember we had some > print there and we got it frequently (let say 10/s). Yeah, this was exactly what I was wondering. > So probably it would be better to have choice to enable this log print > when someone need this information otherwise by default it should be > disabled. Maybe a debug message is better? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k