From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [v3] ath10k: rebuild crypto header in rx data frames
Date: Tue, 31 Oct 2017 15:00:21 +0000 [thread overview]
Message-ID: <8760av1hx8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <52655c07-aba1-525e-8c81-e420eafc329f@dd-wrt.com> (Sebastian Gottschall's message of "Tue, 31 Oct 2017 15:52:15 +0100")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> the following patchlines in the v3 patch look wrong
>
> + /* ICV */
> + if (status->flag & RX_FLAG_ICV_STRIPPED &&
> + enctype != HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2)
> + skb_trim(msdu, msdu->len -
> + ath10k_htt_rx_crypto_tail_len(ar,
> enctype));
>
>
> the enctype != wpa2 isnt enough since it also belongs to ccmp-256,
> gcmp modes etc.
4.14 doesn't support CCMP-256 nor GCMP modes yet. Did you check the
separate patch for 4.15:
https://patchwork.kernel.org/patch/10029097/
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-10-31 15:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 16:36 [PATCH v3] ath10k: rebuild crypto header in rx data frames Kalle Valo
2017-10-27 15:44 ` [v3] " Kalle Valo
2017-10-30 8:39 ` Kalle Valo
2017-10-30 9:32 ` Sebastian Gottschall
2017-10-31 14:52 ` Sebastian Gottschall
2017-10-31 15:00 ` Kalle Valo [this message]
2017-10-31 15:07 ` Sebastian Gottschall
2017-10-31 14:54 ` Sebastian Gottschall
2017-10-31 15:00 ` Vasanthakumar Thiagarajan
2017-11-21 18:54 ` Ben Greear
2017-12-02 14:34 ` Kalle Valo
2017-12-02 21:41 ` Ben Greear
2017-12-03 7:36 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760av1hx8.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox