ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, ath10k@lists.infradead.org
Subject: Re: drivers/net/wireless/ath/ath10k/core.c:79: warning: comparison is always true due to limited range of data type
Date: Mon, 15 Jul 2013 16:22:16 +0300	[thread overview]
Message-ID: <8761wcot4n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20130711072220.GA9811@localhost> (Fengguang Wu's message of "Thu, 11 Jul 2013 15:22:20 +0800")

Hi Fengguang,

Fengguang Wu <fengguang.wu@intel.com> writes:

> FYI, there are new compile warnings show up in
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   6d128e1e72bf082542e85f72e6b7ddd704193588
> commit: 5e3dd157d7e70f0e3cea3f2573ed69fb156a19d5 ath10k: mac80211 driver for Qualcomm Atheros 802.11ac CQA98xx devices
> date:   4 weeks ago
> config: make ARCH=avr32 allyesconfig
>
> All warnings:
>
>    In file included from include/uapi/linux/param.h:4,
>                     from include/linux/timex.h:63,
>                     from include/linux/jiffies.h:8,
>                     from include/linux/ktime.h:25,
>                     from include/linux/timer.h:5,
>                     from include/linux/workqueue.h:8,
>                     from include/linux/srcu.h:34,
>                     from include/linux/notifier.h:15,
>                     from include/linux/memory_hotplug.h:6,
>                     from include/linux/mmzone.h:771,
>                     from include/linux/gfp.h:4,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/net/wireless/ath/ath10k/core.c:18:
>    arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined

This doesn't look like fault of ath10k.

>    In file included from arch/avr32/include/asm/param.h:4,
>                     from include/uapi/linux/param.h:4,
>                     from include/linux/timex.h:63,
>                     from include/linux/jiffies.h:8,
>                     from include/linux/ktime.h:25,
>                     from include/linux/timer.h:5,
>                     from include/linux/workqueue.h:8,
>                     from include/linux/srcu.h:34,
>                     from include/linux/notifier.h:15,
>                     from include/linux/memory_hotplug.h:6,
>                     from include/linux/mmzone.h:771,
>                     from include/linux/gfp.h:4,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/net/wireless/ath/ath10k/core.c:18:
>    arch/avr32/include/uapi/asm/param.h:6:1: warning: this is the location of the previous definition
>    drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_check_fw_version':
>>> drivers/net/wireless/ath/ath10k/core.c:79: warning: comparison is
always true due to limited range of data type

Geert already reported this, I'll fix it.

>    In file included from include/uapi/linux/param.h:4,
>                     from include/linux/timex.h:63,
>                     from include/linux/jiffies.h:8,
>                     from include/linux/ktime.h:25,
>                     from include/linux/timer.h:5,
>                     from include/linux/workqueue.h:8,
>                     from include/linux/srcu.h:34,
>                     from include/linux/notifier.h:15,
>                     from include/linux/memory_hotplug.h:6,
>                     from include/linux/mmzone.h:771,
>                     from include/linux/gfp.h:4,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/net/wireless/ath/ath10k/core.c:18:
>    arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined

Same as the first warning.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

       reply	other threads:[~2013-07-15 13:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51de5541.JaeZCuQB+9U6CmRo%fengguang.wu@intel.com>
     [not found] ` <20130711072220.GA9811@localhost>
2013-07-15 13:22   ` Kalle Valo [this message]
2013-07-15 13:43     ` drivers/net/wireless/ath/ath10k/core.c:79: warning: comparison is always true due to limited range of data type Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761wcot4n.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox