From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: speed up hw recovery
Date: Mon, 13 Oct 2014 11:15:41 +0300 [thread overview]
Message-ID: <877g049yhe.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1412847527-25983-4-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 9 Oct 2014 11:38:47 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> In some cases hw recovery was taking an absurdly
> long time due to ath10k waiting for things that
> would never really complete.
>
> Instead of waiting for inevitable timeouts poke
> all completions and wakequeues and check if it's
> still worth waiting.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -685,6 +685,20 @@ static void ath10k_core_restart(struct work_struct *work)
> {
> struct ath10k *ar = container_of(work, struct ath10k, restart_work);
>
> + set_bit(ATH10K_FLAG_CRASH_FLUSH, &ar->dev_flags);
> + barrier();
Please document why the barrier is needed.
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -371,6 +371,11 @@ enum ath10k_dev_flags {
> /* Indicates that ath10k device is during CAC phase of DFS */
> ATH10K_CAC_RUNNING,
> ATH10K_FLAG_CORE_REGISTERED,
> +
> + /* Device has crashed and needs to restart. This indicates any pending
> + * waiters should immediately cancel instead of waiting for a time out.
> + */
> + ATH10K_FLAG_CRASH_FLUSH,
> };
Instead of a dev flag, should this actually be a new state to enum
ath10k_state? The reason I ask, I don't see how we would use this flag
with other states than with ATH10K_STATE_ON. Or is this needed because
of locking?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-10-13 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:38 [PATCH 0/3] ath10k: speed up recovery Michal Kazior
2014-10-09 9:38 ` [PATCH 1/3] ath10k: fix possible bmi crash Michal Kazior
2014-10-09 9:38 ` [PATCH 2/3] ath10k: expose hw restart via debugfs Michal Kazior
2014-10-13 8:07 ` Kalle Valo
2014-10-13 8:45 ` Michal Kazior
2014-10-09 9:38 ` [PATCH 3/3] ath10k: speed up hw recovery Michal Kazior
2014-10-10 6:56 ` Michal Kazior
2014-10-13 8:15 ` Kalle Valo [this message]
2014-10-13 8:29 ` Michal Kazior
2014-10-13 8:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g049yhe.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox