ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: set the AP keepalive timer
Date: Thu, 16 Jan 2014 11:27:10 +0200	[thread overview]
Message-ID: <877ga0uvip.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1389863904-7159-1-git-send-email-yeohchunyeow@gmail.com> (Chun-Yeow Yeoh's message of "Thu, 16 Jan 2014 17:18:24 +0800")

Chun-Yeow Yeoh <yeohchunyeow@gmail.com> writes:

> Set the AP keepalive timer as following:
> ap_keepalive_min_idle_inactive_time_secs to 60 seconds
> ap_keepalive_max_idle_inactive_time_secs to 120 seconds
> ap_keepalive_max_unresponsive_time_secs to 300 seconds
>
> This ensure that the WMI_PEER_STA_KICKOUT_EVENTID is triggered
> by the FW only once the unresponsive timer is expired.
>
> Tested with firmware version 999.999.0.636 but the timer
> is still default to 100 seconds. Tested with firmware 
> version 10.1.467-1, the timer is set according to 
> ap_keepalive_max_unresponsive_time_secs.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>

Heh, bad timing. Yesterday I implemented STA quick kickout and in that
patch I set the same parameters as you did. I just used longer values to
avoid inactivity timeouts triggering in the firmware. We have the same
functionality in hostapd, so there's no need to use the one in firmware.

I'll send my patch after lunch, please take a look at that and see if
it's ok.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2014-01-16  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16  9:18 [PATCH] ath10k: set the AP keepalive timer Chun-Yeow Yeoh
2014-01-16  9:27 ` Kalle Valo [this message]
2014-01-16  9:32   ` Yeoh Chun-Yeow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ga0uvip.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yeohchunyeow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox