From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 3/3] ath10k: make target endianess more explicit
Date: Wed, 27 Aug 2014 10:26:24 +0300 [thread overview]
Message-ID: <878umaxujj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1408961963-3682-4-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Mon, 25 Aug 2014 12:19:23 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Some copy engine structures are target specific
> and are uploaded to the device during
> init/configuration.
>
> This also cleans up a bit diag_mem_read/write
> implicit byteswap mess leaving only
> diag_access_read/write with an implicit endianess
> byteswap.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> static int ath10k_pci_diag_read32(struct ath10k *ar, u32 address, u32 *value)
> {
> - return ath10k_pci_diag_read_mem(ar, address, value, sizeof(u32));
> + __le32 val = 0;
> + int ret;
> +
> + ret = ath10k_pci_diag_read_mem(ar, address, &val, sizeof(__le32));
> + *value = __le32_to_cpu(val);
> +
> + return ret;
> }
For consistency, I folded a patch below. Is that ok?
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -620,7 +620,7 @@ static int ath10k_pci_diag_read32(struct ath10k *ar, u32 address, u32 *value)
__le32 val = 0;
int ret;
- ret = ath10k_pci_diag_read_mem(ar, address, &val, sizeof(__le32));
+ ret = ath10k_pci_diag_read_mem(ar, address, &val, sizeof(val));
*value = __le32_to_cpu(val);
return ret;
https://github.com/kvalo/ath/commit/1850a415873cb34a6f84b699dfb9a283df3252ec
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-27 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 10:19 [PATCH v2 0/3] ath10k: ce fixes 2014-08-08 Michal Kazior
2014-08-25 10:19 ` [PATCH v2 1/3] ath10k: move pci init structures Michal Kazior
2014-08-25 10:19 ` [PATCH v2 2/3] ath10k: dont duplicate service-pipe mapping Michal Kazior
2014-08-25 10:19 ` [PATCH v2 3/3] ath10k: make target endianess more explicit Michal Kazior
2014-08-27 7:26 ` Kalle Valo [this message]
2014-08-27 8:15 ` Michal Kazior
2014-08-27 7:28 ` Kalle Valo
2014-08-27 8:18 ` Michal Kazior
2014-08-27 12:14 ` [PATCH v2 0/3] ath10k: ce fixes 2014-08-08 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878umaxujj.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox