From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WkYgL-0001yS-NC for ath10k@lists.infradead.org; Wed, 14 May 2014 12:53:14 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: Hold tx-lock while detaching htt. References: <1397695357-14028-1-git-send-email-greearb@candelatech.com> Date: Wed, 14 May 2014 15:52:43 +0300 In-Reply-To: (Michal Kazior's message of "Thu, 17 Apr 2014 08:12:06 +0200") Message-ID: <878uq4h690.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: Ben Greear , linux-wireless , "ath10k@lists.infradead.org" Michal Kazior writes: > On 17 April 2014 02:42, wrote: >> From: Ben Greear >> >> And check for null pool in the tx path (which would >> indicate we are detaching). > > Shouldn't we just make sure tx is stopped before we try to detach htt? > Stoping mac80211 queues and synchronize_net() should be sufficient I > think. > > >> @@ -403,6 +412,13 @@ int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *msdu) >> goto err; >> >> spin_lock_bh(&htt->tx_lock); >> + >> + /* Check if we are detached... */ >> + if (! htt->tx_pool) { >> + spin_unlock_bh(&htt->tx_lock); > > Setting `res` would be nice to indicate an error. And there's a space after !. Ben, are you planning to send v2? Or what should we do with this patch? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k