From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Ansuel Smith <ansuelsmth@gmail.com>,
ath10k@lists.infradead.org,
Sven Eckelmann <sven.eckelmann@openmesh.com>
Subject: Re: 160 mhz crash
Date: Tue, 03 Jul 2018 17:58:56 +0300 [thread overview]
Message-ID: <87a7r8pdqn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <c5cb2d9f-cbda-be1b-cdd8-cbae3b7886be@dd-wrt.com> (Sebastian Gottschall's message of "Thu, 28 Jun 2018 11:56:02 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> Am 28.06.2018 um 08:46 schrieb Sven Eckelmann:
>> On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote:
>>> this is normal. i already posted a patch on this mailinglist to resolve
>>> this issue, but
>>>
>>> but it hasnt found its way to the main source yes.
>> Problem seems to be that the patch [1] has obvious style problems and open
>> questions.
>
> i understand that. but i dont see a problem with the code style since
> the patch is small and not bad looking and on the second hand i was
> tired to finish the discussion. it was frustrating me anyone is
> welcome to enhance it.
And this is why I don't even try to give review comments to your patches
anymore, as it would be waste of my time as shown above. If you want to
have your patches applied, you need to have productive attitude and
willing to receive review comments.
I have been hoping to clean up the patch myself, but I have not managed
to do it yet. If someone else can jump in and finish the patch, I would
be very grateful. I think the biggest work is to cleanup all the
checkpatch warnings and add a check for the WMI service flag.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-07-03 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 21:04 160 mhz crash Ansuel Smith
2018-06-16 8:11 ` Sebastian Gottschall
2018-06-28 6:46 ` Sven Eckelmann
2018-06-28 9:56 ` Sebastian Gottschall
2018-07-03 14:58 ` Kalle Valo [this message]
2018-07-04 6:05 ` Sebastian Gottschall
2018-06-28 9:56 ` Sebastian Gottschall
2018-06-28 12:24 ` Sven Eckelmann
2018-06-29 4:12 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7r8pdqn.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=s.gottschall@dd-wrt.com \
--cc=sven.eckelmann@openmesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox